Bug 91645 – [Qt][WK2] Map the elementRect exposed in QML to the view for popup menu

• Component: New Bugs
• Status: RESOLVED FIXED

[Pierre Rossi]

[Qt][WK2] Map the elementRect exposed in QML to the view for popup menu

[Pierre Rossi]

Created attachment 153057 [details]
Patch

[Simon Hausmann]

Comment on attachment 153057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153057&action=review

> Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:102
>      Q_PROPERTY(QObject* items READ items CONSTANT FINAL)
>  
>  public:
> -    ItemSelectorContextObject(const IntRect& elementRect, const Vector<WebPopupItem>&, int selectedIndex);
> +    ItemSelectorContextObject(const QRectF& elementRect, const Vector<WebPopupItem>&, int selectedIndex);
>  
> -    QRect elementRect() const { return m_elementRect; }
> +    QRectF elementRect() const { return m_elementRect; }
>      PopupMenuItemModel* items() { return &m_items; }
>  
> +    Q_INVOKABLE int itemCount() const { return m_items.rowCount(); }

I think there's an API problem here, that's strictly speaking unrelated to your patch.

If "items" is the model, then shouldn't it be called "model" perhaps?

Anyway, I don't think itemCount() should be an invokable method. Instead all models in QML seem to have a "count" _property_ instead, and I think that's what we should have, too.

[Pierre Rossi]

Created attachment 153246 [details]
Patch

[WebKit Review Bot]

Comment on attachment 153246 [details]
Patch

Clearing flags on attachment: 153246

Committed r123103: <http://trac.webkit.org/changeset/123103>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.