Bug 91635

Summary: [chromium] Fix style for numeric literals in chromium unit test code
Product: WebKit Reporter: Shawn Singh <shawnsingh>
Component: Layout and RenderingAssignee: Shawn Singh <shawnsingh>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Shawn Singh 2012-07-18 10:16:14 PDT 
Patch coming in a moment, which updates unit test code to be consistent with WebKit style for numeric literals.  Specifically, I tried to find most places where extra ".0" or "f" suffixes were being used and remove them.

A couple of places I did not modify:
- division denominators should be left alone, so that they do not accidentally do integer division.
- Color(...) constructors should be left alone, since there are overloaded integer and floating point constructors.
Comment 1 Shawn Singh 2012-07-18 10:23:56 PDT 
Created attachment 153038 [details]
Patch
Comment 2 Adrienne Walker 2012-07-18 10:25:01 PDT 
Comment on attachment 153038 [details]
Patch

R=me.  Thanks for the cleanup.
Comment 3 WebKit Review Bot 2012-07-18 11:26:10 PDT 
Comment on attachment 153038 [details]
Patch

Clearing flags on attachment: 153038

Committed r122993: <http://trac.webkit.org/changeset/122993>
Comment 4 WebKit Review Bot 2012-07-18 11:26:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Shawn Singh 2012-07-18 11:59:11 PDT 
And just post-conclusion for future reference sqrt(2) is ambiguous and causes build errors, so it should remain sqrt(2.0)

Thanks to Tony Chang for gardening that - http://trac.webkit.org/changeset/122997