Bug 91603

Summary: REGRESSION(r117738): [Forms] Default step base should be 0 (=1970-01) for input type month
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch 1
none
Patch 2 none

Description yosin 2012-07-18 02:02:26 PDT 
Before r117738, default step base for input type month is defined in InputType::defaultStepBase() as 0 (=1970-01).
On r117738, it is defined in MonthInputType::createStepRange and it is DateComponents::minimumMonth() (=0001-01).
Comment 1 yosin 2012-07-18 02:16:23 PDT 
Created attachment 152965 [details]
Patch 1
Comment 2 yosin 2012-07-18 02:17:21 PDT 
Comment on attachment 152965 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-07-18 02:37:59 PDT 
Comment on attachment 152965 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=152965&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests. Existing test(fast/forms/month-stepup-stepdown-from-renderer.html)

fast/forms/month-stepup... -> fast/forms/month/month-stepup...
Comment 4 yosin 2012-07-18 02:40:59 PDT 
Created attachment 152972 [details]
Patch 2
Comment 5 yosin 2012-07-18 02:41:58 PDT 
Comment on attachment 152972 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since last review =
* Update path of existing test in ChangeLog
Comment 6 Kent Tamura 2012-07-18 02:45:26 PDT 
Comment on attachment 152972 [details]
Patch 2

ok
Comment 7 yosin 2012-07-18 02:47:36 PDT 
Comment on attachment 152972 [details]
Patch 2

Clearing flags on attachment: 152972

Committed r122937: <http://trac.webkit.org/changeset/122937>
Comment 8 yosin 2012-07-18 02:47:42 PDT 
All reviewed patches have been landed.  Closing bug.