Bug 91595

Summary: [Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, noam, skyul
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dongseong Hwang
Reported 2012-07-18 00:17:32 PDT
Currently, TextureMapperLayer creates a imageBuffer as big as m_state.needsDisplayRect. The size of m_state.needsDisplayRect can be bigger than the size of the layerRect, so we may consumed the memory more than the size of the layerRect. This patch makes TextureMapperLayer save the memory.
Attachments
Patch (2.03 KB, patch)
2012-07-18 00:19 PDT, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-07-18 00:19:40 PDT
Created attachment 152948 [details] Patch
Dongseong Hwang
Comment 2 2012-07-18 00:23:50 PDT
When I tested in http://www.satine.org/research/webkit/snowleopard/snowstack.html , m_state.needsDisplayRect was {m_location = {m_x = 97623, m_y = 20744}, m_size = {m_width = 43797, m_height = 26438}} and WebKit crashed. I don't know why RenderLayerBacking notifies too big dirtyRect to GraphicsLayer.
Kwang Yul Seo
Comment 3 2012-07-18 08:13:45 PDT
Comment on attachment 152948 [details] Patch Clearing flags on attachment: 152948 Committed r122975: <http://trac.webkit.org/changeset/122975>
Kwang Yul Seo
Comment 4 2012-07-18 08:13:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.