Bug 91595

Summary:

[Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.

Product:

WebKit

Reporter:

Dongseong Hwang <dongseong.hwang>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mrobinson, noam, skyul

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Dongseong Hwang 2012-07-18 00:17:32 PDT

Currently, TextureMapperLayer creates a imageBuffer as big as
m_state.needsDisplayRect. The size of m_state.needsDisplayRect can be bigger
than the size of the layerRect, so we may consumed the memory more than the size
of the layerRect.
This patch makes TextureMapperLayer save the memory.

Comment 1 Dongseong Hwang 2012-07-18 00:19:40 PDT

Created attachment 152948 [details]
Patch

Comment 2 Dongseong Hwang 2012-07-18 00:23:50 PDT

When I tested in http://www.satine.org/research/webkit/snowleopard/snowstack.html , m_state.needsDisplayRect was {m_location = {m_x = 97623, m_y = 20744}, m_size = {m_width = 43797, m_height = 26438}} and WebKit crashed.

I don't know why RenderLayerBacking notifies too big dirtyRect to GraphicsLayer.

Comment 3 Kwang Yul Seo 2012-07-18 08:13:45 PDT

Comment on attachment 152948 [details]
Patch

Clearing flags on attachment: 152948

Committed r122975: <http://trac.webkit.org/changeset/122975>

Comment 4 Kwang Yul Seo 2012-07-18 08:13:54 PDT

All reviewed patches have been landed.  Closing bug.