Bug 91582

Summary: [WK2][EFL] TILED_BACKING_STORE support on Efl WebKit2
Product: WebKit Reporter: YoungTaeck Song <youngtaeck.song>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, noam, rakuco, sw0524.lee, webkit.review.bot, yoon
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch
none
Patch none

Description YoungTaeck Song 2012-07-17 22:34:54 PDT
This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
This patch adds TILED_BACKING_STORE related files to CMakeLists.txt and PlatformEfl.cmake
Comment 1 YoungTaeck Song 2012-07-17 22:36:27 PDT
Created attachment 152926 [details]
patch
Comment 2 Gyuyoung Kim 2012-07-17 22:47:39 PDT
Comment on attachment 152926 [details]
patch

Attachment 152926 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13278393
Comment 3 Chris Dumez 2012-07-17 23:03:07 PDT
Comment on attachment 152926 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152926&action=review

> Source/WebKit/efl/ChangeLog:8
> +        Add a dummy funtion for fixing building error when enable TILED_BACKING_STORE.

"when enabling"

> Source/WebKit2/ChangeLog:9
> +        Add a dummy funtion for fixing building error when enable TILED_BACKING_STORE.

"function", "when enabling"
Comment 4 YoungTaeck Song 2012-07-17 23:15:22 PDT
Created attachment 152936 [details]
Patch
Comment 5 YoungTaeck Song 2012-07-17 23:16:54 PDT
(In reply to comment #3)

Thank you for kind review.
> (From update of attachment 152926 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=152926&action=review
> 
> > Source/WebKit/efl/ChangeLog:8
> > +        Add a dummy funtion for fixing building error when enable TILED_BACKING_STORE.
> 
> "when enabling"

fixed.

> 
> > Source/WebKit2/ChangeLog:9
> > +        Add a dummy funtion for fixing building error when enable TILED_BACKING_STORE.
> 
> "function", "when enabling"

fixed.
Comment 6 WebKit Review Bot 2012-07-29 23:10:12 PDT
Comment on attachment 152936 [details]
Patch

Clearing flags on attachment: 152936

Committed r123998: <http://trac.webkit.org/changeset/123998>
Comment 7 WebKit Review Bot 2012-07-29 23:10:17 PDT
All reviewed patches have been landed.  Closing bug.