Bug 91577

Summary:

Symbols only referred from WebCoreTestSupport could be removed from def files.

Product:

WebKit

Reporter:

Hajime Morrita <morrita>

Component:

Tools / Tests

Assignee:

Hajime Morrita <morrita>

Status:

NEW

Severity:

Normal

CC:

abarth, cmarcelo, dglazkov, eric, gustavo, japhet, jochen, mifenton, philn, rniwa, tkent, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from gce-cr-linux-07	none
Patch	gustavo: commit-queue-

Hajime Morrita

Reported 2012-07-17 21:44:32 PDT

Symbols which are only referred from WebCoreTestSupport can be removed by replacing with WEBCORE_TESTING. The target file is WebKit2.def, WebKit2CFLite.def and symbols.filter

Attachments
Patch (55.17 KB, patch) 2012-07-18 19:41 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (55.56 KB, patch) 2012-07-18 21:50 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (66.47 KB, patch) 2012-07-18 22:16 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (67.15 KB, patch) 2012-07-18 23:51 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (67.15 KB, patch) 2012-07-19 00:59 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (68.82 KB, patch) 2012-07-19 01:41 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (70.12 KB, patch) 2012-07-19 02:35 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (71.29 KB, patch) 2012-07-19 22:10 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-07 (1.28 MB, application/zip) 2012-07-19 23:06 PDT, WebKit Review Bot	no flags	Details
Patch (70.15 KB, patch) 2012-07-22 20:24 PDT, Hajime Morrita	gustavo: commit-queue-	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Hajime Morrita

Comment 1 2012-07-18 19:41:02 PDT

Created attachment 153163 [details] Patch

Build Bot

Comment 2 2012-07-18 20:25:49 PDT

Comment on attachment 153163 [details] Patch Attachment 153163 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13275775

Hajime Morrita

Comment 3 2012-07-18 21:50:45 PDT

Created attachment 153177 [details] Patch

Hajime Morrita

Comment 4 2012-07-18 22:16:12 PDT

Created attachment 153178 [details] Patch

Build Bot

Comment 5 2012-07-18 22:52:18 PDT

Comment on attachment 153178 [details] Patch Attachment 153178 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13281801

Hajime Morrita

Comment 6 2012-07-18 23:51:35 PDT

Created attachment 153191 [details] Patch

Gyuyoung Kim

Comment 7 2012-07-19 00:55:03 PDT

Comment on attachment 153191 [details] Patch Attachment 153191 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13275833

Early Warning System Bot

Comment 8 2012-07-19 00:57:54 PDT

Comment on attachment 153191 [details] Patch Attachment 153191 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13272777

Hajime Morrita

Comment 9 2012-07-19 00:59:20 PDT

Created attachment 153201 [details] Patch

Build Bot

Comment 10 2012-07-19 01:31:05 PDT

Comment on attachment 153201 [details] Patch Attachment 153201 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13269838

Hajime Morrita

Comment 11 2012-07-19 01:41:26 PDT

Created attachment 153208 [details] Patch

Build Bot

Comment 12 2012-07-19 02:10:29 PDT

Comment on attachment 153208 [details] Patch Attachment 153208 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13281837

Hajime Morrita

Comment 13 2012-07-19 02:35:01 PDT

Created attachment 153213 [details] Patch

Gustavo Noronha (kov)

Comment 14 2012-07-19 03:04:26 PDT

Comment on attachment 153213 [details] Patch Attachment 153213 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13274791

Build Bot

Comment 15 2012-07-19 06:09:23 PDT

Comment on attachment 153213 [details] Patch Attachment 153213 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13281896

Hajime Morrita

Comment 16 2012-07-19 22:10:54 PDT

Created attachment 153408 [details] Patch

WebKit Review Bot

Comment 17 2012-07-19 23:06:07 PDT

Comment on attachment 153408 [details] Patch Attachment 153408 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13308158 New failing tests: css3/filters/effect-opacity.html

WebKit Review Bot

Comment 18 2012-07-19 23:06:12 PDT

Created attachment 153422 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Hajime Morrita

Comment 19 2012-07-22 20:24:59 PDT

Created attachment 153725 [details] Patch

Gustavo Noronha (kov)

Comment 20 2012-07-22 22:28:53 PDT

Comment on attachment 153725 [details] Patch Attachment 153725 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13314908

Note You need to log in before you can comment on or make changes to this bug.