Bug 91550

Summary: [Chromium] Disable printing on chromium-android
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: bulach, japhet, peter, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2012-07-17 15:45:41 PDT
Disable printing on chromium-android
Attachments
Patch (2.37 KB, patch)
2012-07-17 15:46 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.20 KB, patch)
2012-07-18 15:01 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-07-17 15:46:51 PDT
Created attachment 152855 [details] Patch
Peter Beverloo
Comment 2 2012-07-18 02:11:42 PDT
Comment on attachment 152855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152855&action=review LGTM, thanks! I'll post a patch downstream today to clean this up, as this might cause potential merge confusion. > Source/WebKit/chromium/ChangeLog:3 > + Disable printing on chromium-android nit: Despite mentioning chromium-android in the title, generally [Chromium] as a prefix is clearer. > Source/WebKit/chromium/ChangeLog:8 > + We don't implementing printing on Android. nit: s/implementing/implement/
Adam Barth
Comment 3 2012-07-18 15:01:33 PDT
Created attachment 153096 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-07-18 17:07:29 PDT
Comment on attachment 153096 [details] Patch for landing Clearing flags on attachment: 153096 Committed r123049: <http://trac.webkit.org/changeset/123049>
WebKit Review Bot
Comment 5 2012-07-18 17:07:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.