Bug 91549

Summary: Replace uses of RenderBox::x(), y() in rendering code with with point and size methods
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Emil A Eklund
Reported 2012-07-17 15:39:54 PDT
Replaces uses of RenderBox::x() and RenderBox::y() with RenderBox::location(), RenderBox::locationOffset() and RenderBox::frameRect().
Attachments
Patch (11.68 KB, patch)
2012-07-17 15:49 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.85 KB, patch)
2012-07-18 14:20 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-07-17 15:49:50 PDT
Created attachment 152856 [details] Patch
Eric Seidel (no email)
Comment 2 2012-07-17 22:58:56 PDT
Comment on attachment 152856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152856&action=review LGTM. > Source/WebCore/rendering/RenderBox.cpp:1607 > void RenderBox::repaintDuringLayoutIfMoved(const LayoutRect& rect) Seems this argument should be called oldRect?
Emil A Eklund
Comment 3 2012-07-18 09:55:29 PDT
(In reply to comment #2) > (From update of attachment 152856 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152856&action=review > > LGTM. > > > Source/WebCore/rendering/RenderBox.cpp:1607 > > void RenderBox::repaintDuringLayoutIfMoved(const LayoutRect& rect) > > Seems this argument should be called oldRect? Good idea, will rename before I commit.
Emil A Eklund
Comment 4 2012-07-18 14:20:23 PDT
Created attachment 153086 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-07-18 15:06:47 PDT
Comment on attachment 153086 [details] Patch for landing Clearing flags on attachment: 153086 Committed r123025: <http://trac.webkit.org/changeset/123025>
WebKit Review Bot
Comment 6 2012-07-18 15:06:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.