Bug 91548

Summary: Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
Product: WebKit Reporter: Scott Graham <scottmg>
Component: New BugsAssignee: Scott Graham <scottmg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, haraken, japhet, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Scott Graham 2012-07-17 15:22:00 PDT 
Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
Comment 1 Scott Graham 2012-07-17 15:26:10 PDT 
Created attachment 152847 [details]
Patch
Comment 2 Adam Barth 2012-07-17 15:36:35 PDT 
LGTM, but haraken should review.
Comment 3 WebKit Review Bot 2012-07-17 15:45:04 PDT 
Comment on attachment 152847 [details]
Patch

Attachment 152847 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13279291
Comment 4 Scott Graham 2012-07-17 15:56:11 PDT 
Created attachment 152859 [details]
Patch
Comment 5 Scott Graham 2012-07-17 16:09:04 PDT 
Created attachment 152861 [details]
Patch
Comment 6 Kentaro Hara 2012-07-17 23:33:25 PDT 
Comment on attachment 152861 [details]
Patch

LGTM. Thanks for the great patch!
Comment 7 WebKit Review Bot 2012-07-18 06:43:08 PDT 
Comment on attachment 152861 [details]
Patch

Clearing flags on attachment: 152861

Committed r122963: <http://trac.webkit.org/changeset/122963>
Comment 8 WebKit Review Bot 2012-07-18 06:43:13 PDT 
All reviewed patches have been landed.  Closing bug.