Bug 91548

Summary: Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
Product: WebKit Reporter: Scott Graham <scottmg>
Component: New BugsAssignee: Scott Graham <scottmg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, haraken, japhet, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Scott Graham
Reported 2012-07-17 15:22:00 PDT
Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
Attachments
Patch (3.09 KB, patch)
2012-07-17 15:26 PDT, Scott Graham 		no flags
DetailsFormatted DiffDiff
Patch (3.16 KB, patch)
2012-07-17 15:56 PDT, Scott Graham 		no flags
DetailsFormatted DiffDiff
Patch (3.16 KB, patch)
2012-07-17 16:09 PDT, Scott Graham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Scott Graham
Comment 1 2012-07-17 15:26:10 PDT
Created attachment 152847 [details] Patch
Adam Barth
Comment 2 2012-07-17 15:36:35 PDT
LGTM, but haraken should review.
WebKit Review Bot
Comment 3 2012-07-17 15:45:04 PDT
Comment on attachment 152847 [details] Patch Attachment 152847 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13279291
Scott Graham
Comment 4 2012-07-17 15:56:11 PDT
Created attachment 152859 [details] Patch
Scott Graham
Comment 5 2012-07-17 16:09:04 PDT
Created attachment 152861 [details] Patch
Kentaro Hara
Comment 6 2012-07-17 23:33:25 PDT
Comment on attachment 152861 [details] Patch LGTM. Thanks for the great patch!
WebKit Review Bot
Comment 7 2012-07-18 06:43:08 PDT
Comment on attachment 152861 [details] Patch Clearing flags on attachment: 152861 Committed r122963: <http://trac.webkit.org/changeset/122963>
WebKit Review Bot
Comment 8 2012-07-18 06:43:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.