Summary: | REGRESSION (r89900): Assertion failure on null view() when destroying the document | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Elliott Sprehn <esprehn> | ||||||||
Component: | Layout and Rendering | Assignee: | Elliott Sprehn <esprehn> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, inferno, jchaffraix, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Elliott Sprehn
2012-07-17 15:20:14 PDT
Created attachment 152846 [details]
Patch
Add checks for document destruction when attaching nodes
Comment on attachment 152846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152846&action=review Looks like you forgot to attach the testcase. We don't want to regress on this, so a testcase is good. > Source/WebCore/ChangeLog:3 > + Unneeded tree walking when adding or removing children due to RenderCounter / RenderQuote logic Please fix this title with Regression(rXYZ): Crash in ... (In reply to comment #2) > (From update of attachment 152846 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152846&action=review > > Looks like you forgot to attach the testcase. We don't want to regress on this, so a testcase is good. I don't understand how to write this test. The ClusterFuzz test infinitely reloads the page so it'll never be "done". Should I be appending something to the URL to stop the infinite reload? <!DOCTYPE html> <script>if (window.testRunner) { testRunner.waitUntilDone(); testRunner.dumpAsText(); } </script> <meta http-equiv="refresh" content="0"> <style> section::after { float: left; content: open-quote; } </style> <section> <div></div> Example </section> (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 152846 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=152846&action=review > > > > Looks like you forgot to attach the testcase. We don't want to regress on this, so a testcase is good. > > I don't understand how to write this test. The ClusterFuzz test infinitely reloads the page so it'll never be "done". Should I be appending something to the URL to stop the infinite reload? Yeah,see http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/LayoutTests/svg/custom/bug86392.html&exact_package=chromium&q=%22location.hash%20=%22%20file:layouttests&type=cs&l=41 as an example. you just need one reload. > > <!DOCTYPE html> > <script>if (window.testRunner) { > testRunner.waitUntilDone(); > testRunner.dumpAsText(); > } > </script> > <meta http-equiv="refresh" content="0"> > <style> > section::after { > float: left; > content: open-quote; > } > </style> > > <section> > <div></div> > Example > </section> Created attachment 153110 [details]
Patch
Add test
Comment on attachment 153110 [details]
Patch
r=me
Created attachment 153129 [details]
Patch for landing
Comment on attachment 153129 [details] Patch for landing Clearing flags on attachment: 153129 Committed r123060: <http://trac.webkit.org/changeset/123060> All reviewed patches have been landed. Closing bug. |