| Summary: | [BlackBerry] Move about: URL handling out of WebCore | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yong Li <yong.li.webkit> | ||||||||||||||
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | gyuyoung.kim, mifenton, rakuco, tonikitoo, webkit.review.bot | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Yong Li
2012-07-17 14:05:09 PDT
Created attachment 152835 [details]
the patch
Attachment 152835 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:20: You should add a blank line after implementation file's own header. [build/include_order] [4]
Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 153029 [details]
try again
Comment on attachment 153029 [details] try again View in context: https://bugs.webkit.org/attachment.cgi?id=153029&action=review Looks good. > Source/WebKit/blackberry/Api/WebPage_p.h:100 > + bool loadAbout(const char* aboutURL); Could it be const? Comment on attachment 153029 [details] try again Clearing flags on attachment: 153029 Committed r122992: <http://trac.webkit.org/changeset/122992> All reviewed patches have been landed. Closing bug. should be moved to the right place Created attachment 153824 [details]
move to a new place
Attachment 153824 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1
Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:359: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 153828 [details]
fix style
Comment on attachment 153828 [details] fix style View in context: https://bugs.webkit.org/attachment.cgi?id=153828&action=review Looks good, still some issues. > Source/WebKit/blackberry/ChangeLog:11 > + Other changes: Remove about:version which makes little sense. Make about:memory partially visible. Bu about:version is still in use. > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:397 > + WTF::RefPtr<SharedBuffer> buffer = SharedBuffer::create(source.is8Bit() ? reinterpret_cast<const char*>(source.characters8()) : source.latin1().data(), source.length()); No WTF:: prefix needed. > Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:328 > + } else if (equalIgnoringCase(aboutWhat, "cache")) { We seem to be dealing with cache a lot, how about an if block for when aboutWhat starts with "cache" and then do the subtests? > Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:344 > + result.append(String("<html><head><title>BlackBerry Browser Disk Cache</title></head><body>Http disk cache is enabled.</body></html>")); These two blocks are so similar that maybe a helper function can be added for them. Created attachment 153852 [details]
More cleanups
Attachment 153852 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1
Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:394: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 153852 [details] More cleanups View in context: https://bugs.webkit.org/attachment.cgi?id=153852&action=review Looks good. > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:397 > + WTF::RefPtr<SharedBuffer> buffer = SharedBuffer::create(source.is8Bit() ? reinterpret_cast<const char*>(source.characters8()) : source.latin1().data(), source.length()); You forgot to remove the WTF:: prefix :) Created attachment 153858 [details]
fix style
Comment on attachment 153858 [details] fix style Clearing flags on attachment: 153858 Committed r123391: <http://trac.webkit.org/changeset/123391> All reviewed patches have been landed. Closing bug. |