Bug 91541

Summary:

[BlackBerry] Move about: URL handling out of WebCore

Product:

WebKit

Reporter:

Yong Li <yong.li.webkit>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, mifenton, rakuco, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch	none
try again	none
move to a new place	none
fix style	rwlbuis: review-
More cleanups	rwlbuis: review+
fix style	none

Yong Li

Reported 2012-07-17 14:05:09 PDT

To move about: URL handling from network layer to WebKit/blackberry

Attachments
the patch (57.46 KB, patch) 2012-07-17 14:36 PDT, Yong Li	no flags	Details Formatted Diff Diff
try again (57.43 KB, patch) 2012-07-18 09:42 PDT, Yong Li	no flags	Details Formatted Diff Diff
move to a new place (16.01 KB, patch) 2012-07-23 11:56 PDT, Yong Li	no flags	Details Formatted Diff Diff
fix style (16.00 KB, patch) 2012-07-23 12:00 PDT, Yong Li	rwlbuis: review-	Details Formatted Diff Diff
More cleanups (16.59 KB, patch) 2012-07-23 13:39 PDT, Yong Li	rwlbuis: review+	Details Formatted Diff Diff
fix style (16.57 KB, patch) 2012-07-23 14:05 PDT, Yong Li	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Yong Li

Comment 1 2012-07-17 14:36:07 PDT

Created attachment 152835 [details] the patch

WebKit Review Bot

Comment 2 2012-07-17 14:40:27 PDT

Attachment 152835 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:20: You should add a blank line after implementation file's own header. [build/include_order] [4] Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yong Li

Comment 3 2012-07-18 09:42:45 PDT

Created attachment 153029 [details] try again

Rob Buis

Comment 4 2012-07-18 09:57:59 PDT

Comment on attachment 153029 [details] try again View in context: https://bugs.webkit.org/attachment.cgi?id=153029&action=review Looks good. > Source/WebKit/blackberry/Api/WebPage_p.h:100 > + bool loadAbout(const char* aboutURL); Could it be const?

WebKit Review Bot

Comment 5 2012-07-18 11:25:19 PDT

Comment on attachment 153029 [details] try again Clearing flags on attachment: 153029 Committed r122992: <http://trac.webkit.org/changeset/122992>

WebKit Review Bot

Comment 6 2012-07-18 11:25:24 PDT

All reviewed patches have been landed. Closing bug.

Yong Li

Comment 7 2012-07-23 09:38:51 PDT

should be moved to the right place

Yong Li

Comment 8 2012-07-23 11:56:04 PDT

Created attachment 153824 [details] move to a new place

WebKit Review Bot

Comment 9 2012-07-23 11:57:35 PDT

Attachment 153824 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1 Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:359: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yong Li

Comment 10 2012-07-23 12:00:37 PDT

Created attachment 153828 [details] fix style

Rob Buis

Comment 11 2012-07-23 12:37:58 PDT

Comment on attachment 153828 [details] fix style View in context: https://bugs.webkit.org/attachment.cgi?id=153828&action=review Looks good, still some issues. > Source/WebKit/blackberry/ChangeLog:11 > + Other changes: Remove about:version which makes little sense. Make about:memory partially visible. Bu about:version is still in use. > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:397 > + WTF::RefPtr<SharedBuffer> buffer = SharedBuffer::create(source.is8Bit() ? reinterpret_cast<const char*>(source.characters8()) : source.latin1().data(), source.length()); No WTF:: prefix needed. > Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:328 > + } else if (equalIgnoringCase(aboutWhat, "cache")) { We seem to be dealing with cache a lot, how about an if block for when aboutWhat starts with "cache" and then do the subtests? > Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:344 > + result.append(String("<html><head><title>BlackBerry Browser Disk Cache</title></head><body>Http disk cache is enabled.</body></html>")); These two blocks are so similar that maybe a helper function can be added for them.

Yong Li

Comment 12 2012-07-23 13:39:01 PDT

Created attachment 153852 [details] More cleanups

WebKit Review Bot

Comment 13 2012-07-23 13:42:10 PDT

Attachment 153852 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1 Source/WebKit/blackberry/WebKitSupport/AboutData.cpp:394: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Rob Buis

Comment 14 2012-07-23 13:58:51 PDT

Comment on attachment 153852 [details] More cleanups View in context: https://bugs.webkit.org/attachment.cgi?id=153852&action=review Looks good. > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:397 > + WTF::RefPtr<SharedBuffer> buffer = SharedBuffer::create(source.is8Bit() ? reinterpret_cast<const char*>(source.characters8()) : source.latin1().data(), source.length()); You forgot to remove the WTF:: prefix :)

Yong Li

Comment 15 2012-07-23 14:05:50 PDT

Created attachment 153858 [details] fix style

WebKit Review Bot

Comment 16 2012-07-23 15:34:30 PDT

Comment on attachment 153858 [details] fix style Clearing flags on attachment: 153858 Committed r123391: <http://trac.webkit.org/changeset/123391>

WebKit Review Bot

Comment 17 2012-07-23 15:34:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.