Bug 91473

Summary: "in body" insertion mode, "any other end tag" step 2.1 is updated
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: DOMAssignee: Kwang Yul Seo <skyul>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kwang Yul Seo
Reported 2012-07-17 00:12:34 PDT
Eric filed a bug with HTML5: "in body" insertion mode, "any other end tag", step 2.2 seems wrong. https://www.w3.org/Bugs/Public/show_bug.cgi?id=10080 Since then the HTML5 spec is updated to change the 'end tag' processing to not imply its own end tag, since that makes no sense. http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#parsing-main-inbody 2.1 Generate implied end tags. -> 2.1 Generate implied end tags, except for elements with the same tag name as the token.
Attachments
Patch (2.91 KB, patch)
2012-07-17 01:02 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2012-07-17 01:02:45 PDT
Created attachment 152710 [details] Patch
Eric Seidel (no email)
Comment 2 2012-07-17 02:12:33 PDT
Comment on attachment 152710 [details] Patch OK.
WebKit Review Bot
Comment 3 2012-07-17 02:59:49 PDT
Comment on attachment 152710 [details] Patch Clearing flags on attachment: 152710 Committed r122831: <http://trac.webkit.org/changeset/122831>
WebKit Review Bot
Comment 4 2012-07-17 02:59:53 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 5 2012-07-17 10:47:23 PDT
Is there any observable change in behavior with this change? If so, we should have added a test.
Kwang Yul Seo
Comment 6 2012-07-17 15:07:04 PDT
(In reply to comment #5) > Is there any observable change in behavior with this change? If so, we should have added a test. As I mentioned briefly in the change log, there is no observable change in behavior. This patch reduces parse errors, but that's not observable because HTMLTreeBuilder::parseError(AtomicToken&) is just an empty marker.
Adam Barth
Comment 7 2012-07-17 15:24:24 PDT
Thanks!
Note You need to log in before you can comment on or make changes to this bug.