Summary: | [chromium] Remove awkward anchorPoint usage that implicitly affects layer position | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shawn Singh <shawnsingh> | ||||||||||
Component: | Layout and Rendering | Assignee: | Shawn Singh <shawnsingh> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cc-bugs, danakj, dglazkov, enne, jamesr, vangelis, webkit.review.bot, zlieber | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 80622 | ||||||||||||
Attachments: |
|
Description
Shawn Singh
2012-07-17 00:08:02 PDT
Created attachment 152709 [details]
Patch
(In reply to comment #1) > Created an attachment (id=152709) [details] > Patch Passes unit tests and layout tests on mac. One test will need rebaselining after this patch, but it looks like that test didn't behave correctly before. After this patch, it behaves same/similar to Safari, and I think its correct. Created attachment 152711 [details]
Patch
Same patch, rebased to tip of tree
Comment on attachment 152711 [details] Patch Attachment 152711 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13272089 New failing tests: compositing/reflections/nested-reflection-anchor-point.html CCDamageTrackerTest.verifyDamageForReplicaMaskWithAnchor CCLayerTreeHostImplTest.pageScaleDeltaAppliedToRootScrollLayerOnly CCLayerTreeHostCommonTest.verifyTransformsForRenderSurfaceHierarchy Created attachment 152719 [details]
Archive of layout-test-results from gce-cr-linux-08
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 152796 [details]
Patch
Updated to tip of tree and fixed previous errors
Comment on attachment 152796 [details] Patch R=me. This really cleans things up a lot! I feel pretty comfortable with this given the amount of layout tests that would break if the transform math were wrong. However, CCDamageTrackerTest suffers a lot from http://www.webkit.org/coding/coding-style.html#float-suffixes. Your patch adds a few more, but there's enough in the file that I don't know that it's worth calling out specifically. Committed r122980: <http://trac.webkit.org/changeset/122980> (In reply to comment #7) > (From update of attachment 152796 [details]) > R=me. This really cleans things up a lot! I feel pretty comfortable with this given the amount of layout tests that would break if the transform math were wrong. > > However, CCDamageTrackerTest suffers a lot from http://www.webkit.org/coding/coding-style.html#float-suffixes. Your patch adds a few more, but there's enough in the file that I don't know that it's worth calling out specifically. OK, sounds good. I'm making a patch to clean this up for various unit test files right now. I do strongly disagree with this style rule =) but of course it's more important to stick to the agreed style conventions... (In reply to comment #9) > > I do strongly disagree with this style rule =) but of course it's more important to stick to the agreed style conventions... It's ok to disagree! The list of things I disagree with in the WebKit project is immense. :) |