Bug 91409 – IndexedDB: Implement spec updates to IDBTransaction.error

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Joshua Bell]

In the latest version of the IDB spec:

http://dvcs.w3.org/hg/IndexedDB/rev/aab14b0951ca

* IDBTransaction.error should not throw; return null if transaction not finished.
* If abort() is called on the transaction, error should be null.
* If the transaction was aborted due to an error when committing, error should be a DOMError e.g. UnknownError, QuotaError, etc.
* If an exception bubbles out of a request's error event handler, error should be AbortError even if the event does not have preventDefault called (i.e. not the error event's error)

[Joshua Bell]

Created attachment 152607 [details]
Patch

[Joshua Bell]

dgrogan@, alecflett@ - please take a look?

[David Grogan]

Comment on attachment 152607 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152607&action=review

LGTM

> Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:266
> +        setError(DOMError::create(IDBDatabaseException::getErrorName(IDBDatabaseException::UNKNOWN_ERR)));

Looks like the only way to test this in layout tests is for createIndex(unique=true) to fail because the existing data isn't unique. The quota browser test should hit this also.

There's no WebKit API for the back end to pass the appropriate error?  Is that in the pipeline?

[Joshua Bell]

Comment on attachment 152607 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152607&action=review

>> Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:266
>> +        setError(DOMError::create(IDBDatabaseException::getErrorName(IDBDatabaseException::UNKNOWN_ERR)));
> 
> Looks like the only way to test this in layout tests is for createIndex(unique=true) to fail because the existing data isn't unique. The quota browser test should hit this also.
> 
> There's no WebKit API for the back end to pass the appropriate error?  Is that in the pipeline?

Ah, good point about createIndex() - I'll update the test to include that case.

Yeah, no WebKit API; it should probably be in IDBTransactionCallbacks::onAbort(). I haven't filed a bug yet.

[Joshua Bell]

Created attachment 152633 [details]
Patch

[Joshua Bell]

tony@ - r?

[WebKit Review Bot]

Comment on attachment 152633 [details]
Patch

Clearing flags on attachment: 152633

Committed r122782: <http://trac.webkit.org/changeset/122782>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.