Bug 91296

Summary: LLInt fails to mark structures stored in the bytecode
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: REOPENED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 91298    
Bug Blocks:    
Attachments:
Description Flags
Patch ggaren: review+

Oliver Hunt
Reported 2012-07-13 15:59:26 PDT
LLInt fails to mark structures stored in the bytecode
Attachments
Patch (4.21 KB, patch)
2012-07-13 16:03 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2012-07-13 16:03:23 PDT
Created attachment 152362 [details] Patch
Geoffrey Garen
Comment 2 2012-07-13 16:07:25 PDT
Comment on attachment 152362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152362&action=review r=me > Source/JavaScriptCore/bytecode/CodeBlock.cpp:2252 > + if (!m_globalData->interpreter->classicEnabled() && !!numberOfInstructions() && getJITType() < JITCode::bottomTierJIT()) { Can we merge this with the CLASSIC_INTERPRETER case?
Oliver Hunt
Comment 3 2012-07-13 16:12:22 PDT
Committed r122640: <http://trac.webkit.org/changeset/122640>
WebKit Review Bot
Comment 4 2012-07-13 16:25:28 PDT
Re-opened since this is blocked by 91298
Oliver Hunt
Comment 5 2012-07-13 16:33:20 PDT
Okay, my understanding of what the LLInt expects to do is clearly flawed. Back to trying to work out how it's failing to unlink the resolves correctly.
Note You need to log in before you can comment on or make changes to this bug.