Bug 91296

Summary:

LLInt fails to mark structures stored in the bytecode

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

REOPENED ---

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

91298

Bug Blocks:

Attachments:

Description	Flags
Patch	ggaren: review+

Description Oliver Hunt 2012-07-13 15:59:26 PDT

LLInt fails to mark structures stored in the bytecode

Comment 1 Oliver Hunt 2012-07-13 16:03:23 PDT

Created attachment 152362 [details]
Patch

Comment 2 Geoffrey Garen 2012-07-13 16:07:25 PDT

Comment on attachment 152362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152362&action=review

r=me

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:2252
> +    if (!m_globalData->interpreter->classicEnabled() && !!numberOfInstructions() && getJITType() < JITCode::bottomTierJIT()) {

Can we merge this with the CLASSIC_INTERPRETER case?

Comment 3 Oliver Hunt 2012-07-13 16:12:22 PDT

Committed r122640: <http://trac.webkit.org/changeset/122640>

Comment 4 WebKit Review Bot 2012-07-13 16:25:28 PDT

Re-opened since this is blocked by 91298

Comment 5 Oliver Hunt 2012-07-13 16:33:20 PDT

Okay, my understanding of what the LLInt expects to do is clearly flawed.  Back to trying to work out how it's failing to unlink the resolves correctly.