Summary: | JSC: OfflineASM Pretty printing and commenting enhancements | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fpizlo, ggaren, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2012-07-13 14:30:28 PDT
Created attachment 152353 [details]
Fix.
Attachment 152353 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h:96: Extra space before ) [whitespace/parens] [2]
Total errors found: 1 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The 1 style error is because of I have macros that looks like this: #define OFFLINE_ASM_BEGIN asm ( #define OFFLINE_ASM_END ); The style checker is complaining about the spaces before the ");" because it mistook it for an argument list. I this case, I think the style violation can be allowed as an exception. Comment on attachment 152353 [details] Fix. View in context: https://bugs.webkit.org/attachment.cgi?id=152353&action=review Looks good to me. I'd like Phil to take a look too, since he's more familiar with the Ruby driver. I've CC'd him. One comment below. > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:305 > + loadp CodeBlock[cfr], t2 // t2<CodeBlock> = cfr.CodeBlock > + loadi CodeBlock::m_numVars[t2], t2 // t2<size_t> = t2<CodeBlock>.m_numVars It looks like these comments parrot the LL assembly language in a slightly modified form. Perhaps comment dumping mode should just dump the LL assembly. I could see myself using that when I debugged something in the interpreter. Comment on attachment 152353 [details] Fix. Clearing flags on attachment: 152353 Committed r122650: <http://trac.webkit.org/changeset/122650> All reviewed patches have been landed. Closing bug. |