Bug 91265 – cr-ews bot doesn't set CWD correctly when zipping layout test results

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kenneth Russell]

The newly migrated cr-ews bot is setting the CWD incorrectly (one directory too high) when zipping up failed layout test results. Example bug showing this issue: https://bugs.webkit.org/show_bug.cgi?id=76225 .

The extracted zip archive creates 'tmp/layout_test_results' rather than just layout_test_results.

[Eric Seidel (no email)]

Oh, we've had this forever.  I've just never known how to fix it.

context:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L331
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L238

The code which likely needs to change:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L275
or probably:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py#L87
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/workspace.py#L58

[Eric Seidel (no email)]

I suspect that Workspace.create_zip just needs to be passed some sort of -D argument or something to have it cd into the directory before its starts zipping.

[Eric Seidel (no email)]

(In reply to comment #2)
> I suspect that Workspace.create_zip just needs to be passed some sort of -D argument or something to have it cd into the directory before its starts zipping.

Hmm... Or maybe I'm thinking of tar.

We can probably just pass the zip directory as the cwd= in run_command:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/executive.py#L372
and then tell it to zip "."

[Kenneth Russell]

(In reply to comment #1)
> Oh, we've had this forever.  I've just never known how to fix it.

Oops. I thought this was new behavior. Maybe I was confusing this with layout test results coming from Chromium's flakiness dashboard.

[Eric Seidel (no email)]

Created attachment 159801 [details]
Patch

[Kenneth Russell]

Comment on attachment 159801 [details]
Patch

LGTM! Thanks for the fix.

[WebKit Review Bot]

Comment on attachment 159801 [details]
Patch

Rejecting attachment 159801 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13560090

[Eric Seidel (no email)]

Created attachment 161062 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 161062 [details]
Patch for landing

Rejecting attachment 161062 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Kenneth Russel found in /mnt/git/webkit-commit-queue/Tools/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13654509

[Eric Seidel (no email)]

I'll upload a new one with proper spelling shortly.

[Eric Seidel (no email)]

Created attachment 161095 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 161095 [details]
Patch for landing

Rejecting attachment 161095 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 161095 [details]
Patch for landing

Clearing flags on attachment: 161095

Committed r126952: <http://trac.webkit.org/changeset/126952>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.