| Summary: | cr-ews bot doesn't set CWD correctly when zipping layout test results | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||||||
| Component: | Tools / Tests | Assignee: | Eric Seidel (no email) <eric> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, dbates, dpranke, eric, ojan, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Kenneth Russell
2012-07-13 11:04:10 PDT
Oh, we've had this forever. I've just never known how to fix it. context: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L331 http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L238 The code which likely needs to change: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L275 or probably: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py#L87 http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/workspace.py#L58 I suspect that Workspace.create_zip just needs to be passed some sort of -D argument or something to have it cd into the directory before its starts zipping. (In reply to comment #2) > I suspect that Workspace.create_zip just needs to be passed some sort of -D argument or something to have it cd into the directory before its starts zipping. Hmm... Or maybe I'm thinking of tar. We can probably just pass the zip directory as the cwd= in run_command: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/executive.py#L372 and then tell it to zip "." (In reply to comment #1) > Oh, we've had this forever. I've just never known how to fix it. Oops. I thought this was new behavior. Maybe I was confusing this with layout test results coming from Chromium's flakiness dashboard. Created attachment 159801 [details]
Patch
Comment on attachment 159801 [details]
Patch
LGTM! Thanks for the fix.
Comment on attachment 159801 [details] Patch Rejecting attachment 159801 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13560090 Created attachment 161062 [details]
Patch for landing
Comment on attachment 161062 [details] Patch for landing Rejecting attachment 161062 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Kenneth Russel found in /mnt/git/webkit-commit-queue/Tools/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13654509 I'll upload a new one with proper spelling shortly. Created attachment 161095 [details]
Patch for landing
Comment on attachment 161095 [details] Patch for landing Rejecting attachment 161095 [details] from commit-queue. eric@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 161095 [details] Patch for landing Clearing flags on attachment: 161095 Committed r126952: <http://trac.webkit.org/changeset/126952> All reviewed patches have been landed. Closing bug. |