Bug 91243

Summary: [WIN] Fix compilation of JSGlobalData.h with ENABLE(DFG_JIT)
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: JavaScriptCoreAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, ggaren, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Windows 7   
Attachments:
Description Flags
Patch
ggaren: review-, buildbot: commit-queue-
Patch none

Description Patrick R. Gansterer 2012-07-13 07:36:35 PDT 
[WIN] Fix compilation of JSGlobalData.h with ENABLE(DFG_JIT)
Comment 1 Patrick R. Gansterer 2012-07-13 07:39:43 PDT 
Created attachment 152259 [details]
Patch
Comment 2 Build Bot 2012-07-13 08:09:36 PDT 
Comment on attachment 152259 [details]
Patch

Attachment 152259 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13238133
Comment 3 Early Warning System Bot 2012-07-13 08:35:25 PDT 
Comment on attachment 152259 [details]
Patch

Attachment 152259 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13221675
Comment 4 Early Warning System Bot 2012-07-13 08:41:49 PDT 
Comment on attachment 152259 [details]
Patch

Attachment 152259 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13245067
Comment 5 Geoffrey Garen 2012-07-13 08:50:32 PDT 
Comment on attachment 152259 [details]
Patch

Looks like you need #ifdefs around the #pragma.
Comment 6 Patrick R. Gansterer 2012-07-13 09:23:07 PDT 
Created attachment 152277 [details]
Patch

(In reply to comment #5)
> (From update of attachment 152259 [details])
> Looks like you need #ifdefs around the #pragma.

Yup. Added.
Comment 7 Patrick R. Gansterer 2012-07-19 01:04:53 PDT 
ping?
Comment 8 Geoffrey Garen 2012-07-19 11:00:45 PDT 
Comment on attachment 152277 [details]
Patch

r=me
Comment 9 WebKit Review Bot 2012-07-19 11:21:06 PDT 
Comment on attachment 152277 [details]
Patch

Clearing flags on attachment: 152277

Committed r123125: <http://trac.webkit.org/changeset/123125>
Comment 10 WebKit Review Bot 2012-07-19 11:21:11 PDT 
All reviewed patches have been landed.  Closing bug.