|Summary:||ruby1.9 fails in PrettyPatch.rb with invalid byte sequence in UTF-8|
|Product:||WebKit||Reporter:||Simon Pena <spenap>|
|Component:||Tools / Tests||Assignee:||Simon Pena <spenap>|
|Severity:||Normal||CC:||cmarcelo, morrita, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Simon Pena 2012-07-13 03:58:17 PDT
Comment 1 Simon Pena 2012-07-13 04:03:55 PDT
CCing Caio, who added the normalize_line_ending method originally.
Comment 2 Simon Pena 2012-07-13 04:16:13 PDT
Created attachment 152212 [details] Patch
Comment 3 Simon Pena 2012-07-13 04:17:48 PDT
(In reply to comment #2) > Created an attachment (id=152212) [details] > Patch I've attached a patch using Iconv, although, as mentioned in comment #0, it should be better to use String#encode.
Comment 4 Hajime Morrita 2012-07-18 19:25:09 PDT
(In reply to comment #3) > (In reply to comment #2) > > Created an attachment (id=152212) [details] [details] > > Patch > > I've attached a patch using Iconv, although, as mentioned in comment #0, it should be better to use String#encode. Let's do what you think the best :-)
Comment 5 Simon Pena 2012-07-19 01:38:04 PDT
Comment on attachment 152212 [details] Patch OK, I'll try to come up with a proper fix later.
Comment 6 Simon Pena 2012-10-02 00:20:17 PDT
Created attachment 166628 [details] Patch
Comment 7 Simon Pena 2012-10-02 00:23:30 PDT
This new version of the patch uses the "proper" implementation when Ruby's version is >= 1.9 (using the string encode method) and keeps the current one for 1.8.
Comment 8 Hajime Morrita 2012-10-02 22:04:04 PDT
Comment on attachment 166628 [details] Patch Wow, I didn't know that encode() support :fallback option.
Comment 9 WebKit Review Bot 2012-10-03 04:53:45 PDT
Comment on attachment 166628 [details] Patch Clearing flags on attachment: 166628 Committed r130276: <http://trac.webkit.org/changeset/130276>
Comment 10 WebKit Review Bot 2012-10-03 04:53:48 PDT
All reviewed patches have been landed. Closing bug.