Bug 91207

Summary: [EFL] Add *explicit* keyword to constructor which has a parameter
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2012-07-13 02:40:39 PDT
Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.
Attachments
Patch (4.78 KB, patch)
2012-07-13 02:42 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (4.78 KB, patch)
2012-07-13 02:44 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-07-13 02:42:28 PDT
Created attachment 152195 [details] Patch
Gyuyoung Kim
Comment 2 2012-07-13 02:44:29 PDT
Created attachment 152197 [details] Patch
Zoltan Horvath
Comment 3 2012-07-13 03:48:55 PDT
The patch looks okay for me, I'd r+ it if I were a reviewer. ;]
Zoltan Herczeg
Comment 4 2012-07-13 03:49:17 PDT
Comment on attachment 152197 [details] Patch r=me
WebKit Review Bot
Comment 5 2012-07-13 04:24:42 PDT
Comment on attachment 152197 [details] Patch Clearing flags on attachment: 152197 Committed r122563: <http://trac.webkit.org/changeset/122563>
WebKit Review Bot
Comment 6 2012-07-13 04:24:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.