Summary: | DFG CFA may get overzealous in loops that have code that must exit | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | ||||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2012-07-12 20:57:31 PDT
Created attachment 152145 [details]
the patch
I will post the test shortly. Still computing the expected result.
Comment on attachment 152145 [details]
the patch
Ooops. Never mind.
Created attachment 152149 [details]
the patch
Comment on attachment 152149 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=152149&action=review > Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:60 > + m_insertionSetForFolding.execute(*block); This may insert the phantoms in the wrong place, Phi will fix. Created attachment 152152 [details]
the patch
Landed in http://trac.webkit.org/changeset/122541 |