Bug 91185

Summary:

CodeGeneratorJS.pm need to handle the attribute which has "CallWith=ScriptExecutionContext" option.

Product:

WebKit

Reporter:

Dongwoo Joshua Im (dwim) <dw.im>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

abarth, ggaren, haraken, japhet, jochen, kinuko, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Bug Depends on:

Bug Blocks:

79193, 91187

Attachments:

Description	Flags
Patch	none

Dongwoo Joshua Im (dwim)

Reported 2012-07-12 19:52:56 PDT

When I try to build EFL port with enabling the ENABLE_FILE_SYSTEM flag, I met an build error. In the HTMLInputElementFileSystem.h, webkitEntries is defined as below. - static PassRefPtr<EntryArray> webkitEntries(HTMLInputElement*, ScriptExecutionContext*); But, in the JSHtmlInputElement.cpp, it tries to call webkitEntries(ScriptExecutionContext*, HTMLInputElement*). I think CodeGeneratorJS.pm should be fixed. I will upload the patch soon.

Attachments
Patch (1.62 KB, patch) 2012-07-12 20:06 PDT, Dongwoo Joshua Im (dwim)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dongwoo Joshua Im (dwim)

Comment 1 2012-07-12 20:06:01 PDT

Created attachment 152138 [details] Patch

Kentaro Hara

Comment 2 2012-07-12 23:17:51 PDT

Comment on attachment 152138 [details] Patch Good fix! V8 already uses push().

Dongwoo Joshua Im (dwim)

Comment 3 2012-07-12 23:45:10 PDT

(In reply to comment #2) > (From update of attachment 152138 [details]) > Good fix! V8 already uses push(). Dear Kentaro Hara, Thanks for the review! I'm looking for some more points to improve the CodeGeneratorJS.pm. I will refer how V8 does.

WebKit Review Bot

Comment 4 2012-07-12 23:50:30 PDT

Comment on attachment 152138 [details] Patch Clearing flags on attachment: 152138 Committed r122545: <http://trac.webkit.org/changeset/122545>

WebKit Review Bot

Comment 5 2012-07-12 23:50:35 PDT

All reviewed patches have been landed. Closing bug.

Kentaro Hara

Comment 6 2012-07-13 04:03:32 PDT

Reverted r122545 for reason: We found that this was a wrong fix Committed r122561: <http://trac.webkit.org/changeset/122561>

Kentaro Hara

Comment 7 2012-07-13 04:05:09 PDT

Per discussion in IRC, this is a wrong fix.

Note You need to log in before you can comment on or make changes to this bug.