Summary: | Comment on WebCore::HTMLMediaElement::childShouldCreateRenderer() should explain why | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||
Component: | DOM | Assignee: | Hajime Morrita <morrita> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric.carlson, feature-media-reviews, tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Hajime Morrita
2012-07-12 17:38:42 PDT
Created attachment 152124 [details]
Patch
Comment on attachment 152124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152124&action=review > Source/WebCore/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). ? Comment on attachment 152124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152124&action=review > Source/WebCore/html/HTMLMediaElement.cpp:494 > + // be rendered. So this should return true for most of the children. should return false? Created attachment 152168 [details]
Patch
Comment on attachment 152124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152124&action=review >> Source/WebCore/html/HTMLMediaElement.cpp:494 >> + // be rendered. So this should return true for most of the children. > > should return false? Ooops. Thanks for the catch. Just updated the patch. Tried to clarified the comment/made it wrong (your favorite meme here)... Comment on attachment 152168 [details]
Patch
Looks ok.
Comment on attachment 152168 [details]
Patch
I get it now, thanks for taking the time to update the comment!
Comment on attachment 152168 [details] Patch Clearing flags on attachment: 152168 Committed r122786: <http://trac.webkit.org/changeset/122786> All reviewed patches have been landed. Closing bug. |