Summary: | REGRESSION: RenderInline boundingBox ignores relative position offset | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kiran Muppala <cmuppala> | ||||||||
Component: | Layout and Rendering | Assignee: | Kiran Muppala <cmuppala> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cmuppala, eric, simon.fraser, webkit-bug-importer, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Kiran Muppala
2012-07-12 17:11:56 PDT
Created attachment 152127 [details]
Patch
Comment on attachment 152127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152127&action=review > Source/WebCore/rendering/RenderInline.cpp:660 > + m_geometryMap.pushMappingsToAncestor(view, 0); > + m_geometryMap.pushMappingsToAncestor(renderer, view); > + } Does m_geometryMap.pushMappingsToAncestor(renderer, 0); not work? If so, we should just fix RenderGeometryMap so that it does. (In reply to comment #3) > (From update of attachment 152127 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152127&action=review > > > Source/WebCore/rendering/RenderInline.cpp:660 > > + m_geometryMap.pushMappingsToAncestor(view, 0); > > + m_geometryMap.pushMappingsToAncestor(renderer, view); > > + } > > Does m_geometryMap.pushMappingsToAncestor(renderer, 0); not work? If so, we should just fix RenderGeometryMap so that it does. Yes, calling m_geometryMap.pushMappingsToAncestor(renderer, 0) results in the renderer's mapping pushed first, which is exactly what is happening currently. In fact the assertion, ASSERT(!m_mapping.size()), in RenderGeometryMap::pushView fails for such a call. Created attachment 152351 [details]
Patch
Comment on attachment 152351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152351&action=review > LayoutTests/fast/inline/inline-relative-offset-boundingbox.html:14 > + parentRect = parent.getBoundingClientRect(); > + shouldBe("inlineRect.left", "parentRect.left + inlineLeftOffset"); Indentation looks wrong here. Created attachment 152364 [details]
Patch
(In reply to comment #6) > (From update of attachment 152351 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152351&action=review > > > LayoutTests/fast/inline/inline-relative-offset-boundingbox.html:14 > > + parentRect = parent.getBoundingClientRect(); > > + shouldBe("inlineRect.left", "parentRect.left + inlineLeftOffset"); > > Indentation looks wrong here. My bad, there was a tab in the second line. I replaced it with spaces and that fixed the indentation. Uploaded a new patch. Only change is the fix for indentation. Comment on attachment 152364 [details] Patch Clearing flags on attachment: 152364 Committed r122653: <http://trac.webkit.org/changeset/122653> All reviewed patches have been landed. Closing bug. |