Bug 91094

Summary: [Qt] Implement MemoryUsageSupport
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: PlatformAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, haraken, japhet, jochen, ossy, webkit.review.bot
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch abarth: review+

Allan Sandfeld Jensen
Reported 2012-07-12 07:47:19 PDT
We should support the MemoryUsageSupport class, it is currently only used by the V8 garbage-collector, but it can be usefull for us to measure run-time memory-usage more accurately and to implement a memory pressure handler.
Attachments
Patch (10.09 KB, patch)
2012-07-12 07:54 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (10.33 KB, patch)
2012-07-12 08:12 PDT, Allan Sandfeld Jensen 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-07-12 07:54:26 PDT
Created attachment 151952 [details] Patch
WebKit Review Bot
Comment 2 2012-07-12 08:00:40 PDT
Comment on attachment 151952 [details] Patch Attachment 151952 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13180834
Allan Sandfeld Jensen
Comment 3 2012-07-12 08:12:00 PDT
Created attachment 151957 [details] Patch
Adam Barth
Comment 4 2012-07-12 08:23:02 PDT
Comment on attachment 151957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151957&action=review > Source/WebCore/platform/MemoryUsageSupport.h:36 > +// MemoryUsageSupport is currently only used by the V8 garbage collector. I wouldn't add this sort of comment. It's likely to get out of date quickly.
Allan Sandfeld Jensen
Comment 5 2012-07-12 08:27:49 PDT
(In reply to comment #4) > (From update of attachment 151957 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151957&action=review > > > Source/WebCore/platform/MemoryUsageSupport.h:36 > > +// MemoryUsageSupport is currently only used by the V8 garbage collector. > > I wouldn't add this sort of comment. It's likely to get out of date quickly. Okay.
Allan Sandfeld Jensen
Comment 6 2012-07-12 08:34:53 PDT
Committed r122462: <http://trac.webkit.org/changeset/122462>
Csaba Osztrogonác
Comment 7 2012-07-12 09:15:34 PDT
(In reply to comment #6) > Committed r122462: <http://trac.webkit.org/changeset/122462> It broke the 4.8 builds, could you fix it, please? /ramdisk/qt-linux-release/build/Source/WebCore/platform/qt/MemoryUsageSupportQt.cpp:25:45: error: JavaScriptCore/MemoryStatistics.h: No such file or directory
Allan Sandfeld Jensen
Comment 8 2012-07-12 10:08:07 PDT
(In reply to comment #7) > (In reply to comment #6) > > Committed r122462: <http://trac.webkit.org/changeset/122462> > > It broke the 4.8 builds, could you fix it, please? > /ramdisk/qt-linux-release/build/Source/WebCore/platform/qt/MemoryUsageSupportQt.cpp:25:45: error: JavaScriptCore/MemoryStatistics.h: No such file or directory Fixed in r122474.
Note You need to log in before you can comment on or make changes to this bug.