Summary: | [Qt][Mac]REGRESSION(r122400): It broke the build | ||
---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
Component: | Tools / Tests | Assignee: | Mark Rowe (bdash) <mrowe> |
Status: | RESOLVED FIXED | ||
Severity: | Blocker | CC: | jesus, menard, ossy |
Priority: | P1 | Keywords: | Qt, QtTriaged |
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | |||
Bug Blocks: | 91015 |
Description
Csaba Osztrogonác
2012-07-11 22:48:38 PDT
Sorry for the breakage. I watched the bots for an hour or so after landing, but it looks like this one took longer than that to finish building. (In reply to comment #1) > Sorry for the breakage. I watched the bots for an hour or so after landing, but it looks like this one took longer than that to finish building. Not problem, thanks for looking into it. I willingly helped you, but unfortunately I don't have Mac box with Qt build to be able to debug. The Snow Leopard Qt bot appears to be building against the system headers (e.g., no SDK) with a deployment target of 10.5. This means that __MAC_OS_X_VERSION_MIN_REQUIRED will evaluate to 1050 and __MAC_OS_X_VERSION_MAX_ALLOWED will evaluate to 1060. This means that in theory the Leopard-compatible path in DisplaySleepEnabler.cpp should be used. Prior to my change it looks like Qt would have been using the Snow Leopard and newer version of the code because Qt happened to not define BUILDING_ON_LEOPARD. That would result in code that was incompatible with the 10.5 deployment target though. (In reply to comment #4) > This should be fixed in r122421. Yes indeed it is slow as the bot runs on an old Macbook Pro 2,2 and Xcode 4.3 removed the distributed build feature which was working fine for us. Anyway I confirm it is fixed. Thank you. |