Summary: | Regression (r122359) Layout Test html5lib/runner.html is failing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||
Component: | Tools / Tests | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, tony | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Hayato Ito
2012-07-11 21:27:05 PDT
Marked it CRASH. http://trac.webkit.org/changeset/122415 Created attachment 152050 [details]
Patch
Comment on attachment 152050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152050&action=review > LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt:2 > +ALERT: viewport size 320x480 scale 1 with limits [1, 5] and userScalable true > +ALERT: viewport size 320x480 scale 1 with limits [1, 5] and userScalable true Nit: It would be nicer if the test said PASS/FAIL rather than ALERT. Maybe use js-test-pre? > LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html:8 > + XHTML-MP is used for mobile documents which are assumed to be designed for > + handheld devices, hence using the viewport size as the initial containing Nit: Since this is a dumpAsText test, should we just put this in a <p>? These are the style of all the tests in this directory. I agree that the style is kind of goofy. I'm not sure whether it's worth making this one test different from the rest. I don't feel strongly about this one way or another. Feel free to only resolve conflicts and land. I've filed https://bugs.webkit.org/show_bug.cgi?id=91150 about improving these tests as a whole. Committed r122509: <http://trac.webkit.org/changeset/122509> |