Bug 91040

Summary: CommitQueue is confused about what port it is using
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2012-07-11 18:32:05 PDT
CommitQueue is confused about what port it is using
Attachments
Patch (12.12 KB, patch)
2012-07-11 18:34 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (12.53 KB, patch)
2012-07-12 16:39 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-07-11 18:34:44 PDT
Created attachment 151840 [details] Patch
Adam Barth
Comment 2 2012-07-12 16:39:31 PDT
Created attachment 152093 [details] Patch
Adam Barth
Comment 3 2012-07-12 16:40:58 PDT
As discussed, this new version lets you override the port on the command line in case you want to test the commit-queue locally.
Dirk Pranke
Comment 4 2012-07-12 16:44:17 PDT
Comment on attachment 152093 [details] Patch I was hoping someone who knew something about DeprecatedPort would chime in, but guess that time elapsed w/o help. I took a look, and it looks fine to me.
Adam Barth
Comment 5 2012-07-12 16:52:58 PDT
Thanks Dirk. I've been discussing the patch a bit with Eric off-bug. His main concern was the ability to run the commit-queue locally on his machine for debugging purposes. These issues would also largely be fixed if we switched from DeprecatedPort to Port because the default port on Linux is chromium-linux. There's still a slight issue with needing to use XVFB, but that's likely solvable somehow.
WebKit Review Bot
Comment 6 2012-07-12 18:27:10 PDT
Comment on attachment 152093 [details] Patch Clearing flags on attachment: 152093 Committed r122534: <http://trac.webkit.org/changeset/122534>
WebKit Review Bot
Comment 7 2012-07-12 18:27:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.