Bug 91032

Summary: [chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer
Product: WebKit Reporter: Adrienne Walker <enne>
Component: New BugsAssignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, dglazkov, enne, fishd, jamesr, tkent+wkapi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 90528    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Rebased
none
Rebased
none
Patch for landing none

Adrienne Walker
Reported 2012-07-11 16:38:20 PDT
[chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer
Attachments
Patch (14.32 KB, patch)
2012-07-11 16:40 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Rebased (14.34 KB, patch)
2012-07-26 11:08 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Rebased (14.19 KB, patch)
2012-07-30 14:42 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.13 KB, patch)
2012-07-30 15:35 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2012-07-11 16:40:40 PDT
Created attachment 151814 [details] Patch
Adrienne Walker
Comment 2 2012-07-26 11:08:32 PDT
Created attachment 154690 [details] Rebased
Adrienne Walker
Comment 3 2012-07-30 14:42:47 PDT
Created attachment 155368 [details] Rebased
WebKit Review Bot
Comment 4 2012-07-30 14:45:05 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 5 2012-07-30 14:49:52 PDT
Comment on attachment 155368 [details] Rebased View in context: https://bugs.webkit.org/attachment.cgi?id=155368&action=review Awesome! > Source/WebKit/chromium/src/WebScrollbarLayer.cpp:59 > + return static_cast<ScrollbarLayerChromium*>(m_private.get()); does "return unwrap<ScrollbarLayerChromium>()" work instead of the static_cast<>? it's slightly clearer about what it means, IMO
WebKit Review Bot
Comment 6 2012-07-30 15:00:59 PDT
Comment on attachment 155368 [details] Rebased Attachment 155368 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13389451
Adrienne Walker
Comment 7 2012-07-30 15:35:25 PDT
Created attachment 155386 [details] Patch for landing
Adrienne Walker
Comment 8 2012-07-30 15:36:05 PDT
Comment on attachment 155386 [details] Patch for landing (In reply to comment #5) > (From update of attachment 155368 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155368&action=review > > > Source/WebKit/chromium/src/WebScrollbarLayer.cpp:59 > > + return static_cast<ScrollbarLayerChromium*>(m_private.get()); > > does "return unwrap<ScrollbarLayerChromium>()" work instead of the static_cast<>? it's slightly clearer about what it means, IMO Ah, for sure. Fixed.
WebKit Review Bot
Comment 9 2012-07-30 20:03:09 PDT
Comment on attachment 155386 [details] Patch for landing Clearing flags on attachment: 155386 Committed r124160: <http://trac.webkit.org/changeset/124160>
WebKit Review Bot
Comment 10 2012-07-30 20:03:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.