Bug 91009 – [Gtk] fast/xsl/xslt-missing-namespace-in-xslt.xml is failing on the 64-bit Debug builder

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Zan Dobersek]

The test fails only on the 64-bit Debug builder. The OS running on it is Debian Sid (unstable).

Debian Sid provides libxml2 2.8.0. After installing this version of libxml2 locally I can reproduce the failure:
--- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/xsl/xslt-missing-namespace-in-xslt-actual.txt
@@ -2,14 +2,29 @@
 
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x84
-  RenderBlock {html} at (0,0) size 800x84
-    RenderBody {body} at (8,16) size 784x52
+layer at (0,0) size 800x286
+  RenderBlock {html} at (0,0) size 800x286
+    RenderBlock {parsererror} at (16,16) size 768x186 [bgcolor=#FFDDDD] [border: (2px solid #CC7777)]
+      RenderBlock {h3} at (18,20) size 732x22
+        RenderText {#text} at (0,0) size 324x22
+          text run at (0,0) width 324: "This page contains the following errors:"
+      RenderBlock {div} at (18,60) size 732x14
+        RenderText {#text} at (0,0) size 504x14
+          text run at (0,0) width 504: "error on line 1 at column 76: Namespace prefix foo on bar is not defined"
+          text run at (504,0) width 0: " "
+      RenderBlock {h3} at (18,92) size 732x22
+        RenderText {#text} at (0,0) size 429x22
+          text run at (0,0) width 429: "Below is a rendering of the page up to the first error."
+      RenderBlock {p} at (18,132) size 732x36
+        RenderText {#text} at (0,0) size 731x37
+          text run at (0,0) width 731: "This document was created as the result of an XSL transformation. The line and column numbers given are from the"
+          text run at (0,18) width 117: "transformed result."
+    RenderBody {body} at (8,218) size 784x52
       RenderBlock {p} at (0,0) size 784x18
         RenderText {#text} at (0,0) size 227x19
           text run at (0,0) width 227: "You should see error text above this"
       RenderBlock (anonymous) at (0,34) size 784x0
-        RenderInline {bar} at (0,0) size 0x0
+        RenderInline {foo:bar} at (0,0) size 0x0
       RenderBlock {p} at (0,34) size 784x18
         RenderText {#text} at (0,0) size 350x19
           text run at (0,0) width 350: "ERROR? this, and nothing below it should be rendered"

[Martin Robinson]

Perhaps it's best to integrate libxml into the jhbuild. This isn't the first time we've had issues with it.

[Zan Dobersek]

OTOH this looks like a real regression. The libxml2 version will be shipping in Ubuntu 12.10 as well.

I'll try to bisect libxml2 to locate the offending commit, though the process was a pain to do the last time I tried it.

[Zan Dobersek]

It's actually a progression, the commit is
http://git.gnome.org/browse/libxml2/commit/?id=77b77b1301e052d90e6a0967534a698506afcd86

The error is now properly shown, but the text is still rendered underneath it even though it shouldn't be.

Neither Chromium nor Mac port get this right, but Firefox does. I'll attach the GTK and Firefox output to demonstrate.

[Zan Dobersek]

Created attachment 163584 [details]
WebKitGTK+ output

The error is shown, but the text is still rendered, even though it says it shouldn't be.

[Zan Dobersek]

Created attachment 163586 [details]
Firefox output

The error is shown and no text is rendered below it.

[Zan Dobersek]

(In reply to comment #3)
> 
> Neither Chromium nor Mac port get this right, but Firefox does. I'll attach the GTK and Firefox output to demonstrate.

The rendering of the text despite the error is probably cross-platform issue. The jhbuild modules should be updated to include libxml2 2.8.0 and the baselines for this test updated.

[Zan Dobersek]

Created attachment 163613 [details]
Patch

[Zan Dobersek]

Comment on attachment 163613 [details]
Patch

Landed in r130543.
http://trac.webkit.org/changeset/130543