Bug 90992 – Rename HitTestPoint and pointInContainer

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Allan Sandfeld Jensen]

The implementations of the hit-testing function called nodeAtPoint make consistent used of a parameter called pointInContainer of type HitTestPoint. This value is not necessarly a single point however, but can be an area from a rect-based hit test.

To make the code clearer, these values and classes should be renamed to something indicating that they are often more than a point.

[Eric Seidel (no email)]

And How!

[Allan Sandfeld Jensen]

I am currently thinking of renaming HitTestPoint to HitTestLocation, since location is more ambigiously either a point or an area.

At the same time I would rename isRectBased to isAreaBased.

[Antonio Gomes]

Does the term "target" apply well?

[Allan Sandfeld Jensen]

(In reply to comment #3)
> Does the term "target" apply well?

Yes, that is perhaps an even better name.

[Allan Sandfeld Jensen]

Okay, I have started a rename for HitTestPoint to HitTestTarget, but should nodeAtPoint be renamed as well, and in that case: To what?

Neither nodeAtTarget, nor nodesAtTarget really cover all cases. So perhaps a return to hitTest? So far I am leaving it unchanged in the first patch. A better rename can be delayed until we succesfully join nodeAtPoint and nodeAtFloatPoint.

[Allan Sandfeld Jensen]

Created attachment 155243 [details]
Patch

[Allan Sandfeld Jensen]

Created attachment 155246 [details]
Patch

Also rename isRectBased to isAreaBased as promised

[Simon Fraser (smfr)]

Target sounds too much like an event target; it sounds like you've already computed what's getting hit (the target).

How about HitTestArea? I'm OK with HitTestLocation too.

[Allan Sandfeld Jensen]

(In reply to comment #8)
> Target sounds too much like an event target; it sounds like you've already computed what's getting hit (the target).
> 
Right, the target could sound like the result, not the query.

> How about HitTestArea? I'm OK with HitTestLocation too.

I try to avoid hit-test area because it doesn't sound like it can be a single point. Also the term is already used in RenderLayer for the clipping area of the hit-test.

[Allan Sandfeld Jensen]

The recent quadroanual ring-themed sporting event, had me look up what shooting and archery sports call it. Apparently, they talk about where the 'hit' is in the 'target', so target is what they aim for and 'hit' is where they hit it. So if we were to follow that terminology, it would be just HitTestHit (or just Hit), nodeAtHit and hitInContainer.

[Allan Sandfeld Jensen]

Created attachment 160395 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 160395 [details]
Patch

Seems reasonable, and seems Simon agrees.  r=me.  I would also be fine with HitLocation or HitArea.

[WebKit Review Bot]

Comment on attachment 160395 [details]
Patch

Clearing flags on attachment: 160395

Committed r126859: <http://trac.webkit.org/changeset/126859>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.