Bug 90962 – [BlackBerry] We shouldn't call didFinishLoading for the old request when a new request has been sent by notifyAuthReceived.

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Jason Liu]

We should do like 301's handling.

[Jason Liu]

A patch is coming tomorrow.

[Jason Liu]

Created attachment 151868 [details]
Patch

[Rob Buis]

Comment on attachment 151868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151868&action=review

> Source/WebCore/ChangeLog:11
> +        We should do as 3XX.

Any PR? Internal review?

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:-507
> -        return true;

Why was this part removed?

[Jason Liu]

(In reply to comment #3)
> (From update of attachment 151868 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151868&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        We should do as 3XX.
> 
> Any PR? Internal review?
> 
There is no PR for this. I just find this problem when fixing another pr.
> > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:-507
> > -        return true;
> 
> Why was this part removed?
I moved "if (m_redirectCount >= s_redirectMaximum)" to handleRedirect().

[Joe Mason]

Comment on attachment 151868 [details]
Patch

LGTM. Nice catch!

[Rob Buis]

Comment on attachment 151868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151868&action=review

Looks good.

>>> Source/WebCore/ChangeLog:11
>>> +        We should do as 3XX.
>> 
>> There is no PR for this. I just find this problem when fixing another pr.
> 
> Any PR? Internal review?

Ok, you could add Joe Mason as internal reviewer before landing, up to you.

[WebKit Review Bot]

Comment on attachment 151868 [details]
Patch

Clearing flags on attachment: 151868

Committed r122692: <http://trac.webkit.org/changeset/122692>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.