Bug 90919

Summary: Assertion ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()) when compositing in paginated mode
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, gns, koivisto, simon.fraser, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch koivisto: review+

Description Simon Fraser (smfr) 2012-07-10 16:54:42 PDT
ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox())
Source/WebCore/rendering/RenderGeometryMap.cpp(85) : WebCore::FloatRect WebCore::RenderGeometryMap::absoluteRect(const WebCore::FloatRect &) const
1   0x409325a WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer*, WebCore::RenderLayer*, WebCore::RenderLayerCompositor::OverlapMap*, WebCore::CompositingState&, bool&, bool&)
2   0x40936a5 WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer*, WebCore::RenderLayer*, WebCore::RenderLayerCompositor::OverlapMap*, WebCore::CompositingState&, bool&, bool&)
3   0x40937c6 WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer*, WebCore::RenderLayer*, WebCore::RenderLayerCompositor::OverlapMap*, WebCore::CompositingState&, bool&, bool&)
4   0x4092983 WebCore::RenderLayerCompositor::updateCompositingLayers(WebCore::CompositingUpdateType, WebCore::RenderLayer*)
5   0x3266312 WebCore::FrameView::updateCompositingLayersAfterLayout()
6   0x3268965 WebCore::FrameView::layout(bool)
Comment 1 Simon Fraser (smfr) 2012-07-10 16:58:32 PDT
The old code would insert a step with isNonUniform=true when pushing the step from the RenderView to the <html>'s RenderBlock. The new code relies on layer->canUseConvertToLayerCoords(), which checks *this* layer for columns, not the layer of the container.
Comment 2 Simon Fraser (smfr) 2012-07-10 18:20:41 PDT
Created attachment 151568 [details]
Patch
Comment 3 Gyuyoung Kim 2012-07-10 18:24:35 PDT
Comment on attachment 151568 [details]
Patch

Attachment 151568 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13197009
Comment 4 Early Warning System Bot 2012-07-10 18:26:28 PDT
Comment on attachment 151568 [details]
Patch

Attachment 151568 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13212006
Comment 5 Early Warning System Bot 2012-07-10 18:26:42 PDT
Comment on attachment 151568 [details]
Patch

Attachment 151568 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13199149
Comment 6 Gustavo Noronha (kov) 2012-07-10 18:27:44 PDT
Comment on attachment 151568 [details]
Patch

Attachment 151568 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13186124
Comment 7 Build Bot 2012-07-10 18:31:30 PDT
Comment on attachment 151568 [details]
Patch

Attachment 151568 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13182241
Comment 8 WebKit Review Bot 2012-07-10 18:31:48 PDT
Comment on attachment 151568 [details]
Patch

Attachment 151568 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13180252
Comment 9 Simon Fraser (smfr) 2012-07-10 18:34:16 PDT
Created attachment 151570 [details]
Patch
Comment 10 Antti Koivisto 2012-07-11 12:07:00 PDT
Comment on attachment 151570 [details]
Patch

r=me
Comment 11 Simon Fraser (smfr) 2012-07-11 15:27:16 PDT
http://trac.webkit.org/changeset/122376