Summary: | [Gtk] allow building with css-filters | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | arno. <a.renevier> | ||||
Component: | WebCore Misc. | Assignee: | arno. <a.renevier> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, gustavo, mrobinson, webkit.review.bot, zan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
arno.
2012-07-10 13:49:20 PDT
Created attachment 151517 [details]
patch proposal
with this patch, it's possible to build gtk port with css filters support: build-webkit --gtk --css-filters
Comment on attachment 151517 [details]
patch proposal
rs=me.
Just going to cancel the commit queue for the moment, so that Zan can double-check this patch. Zan, do you mind doing an informal review of this patch. I'm not certain if we can skip the addition of the new configuration option or not. (In reply to comment #4) > Zan, do you mind doing an informal review of this patch. I'm not certain if we can skip the addition of the new configuration option or not. I think it's OK to add a configuration flag since it's currently the only way to enable the feature. Later, with GNUmakefile.features.am, it should be determined whether the feature can be enabled by default (at least in developer builds). Comment on attachment 151517 [details] patch proposal Clearing flags on attachment: 151517 Committed r122346: <http://trac.webkit.org/changeset/122346> All reviewed patches have been landed. Closing bug. |