Bug 90908

Summary: [Gtk] allow building with css-filters
Product: WebKit Reporter: arno. <a.renevier>
Component: WebCore Misc.Assignee: arno. <a.renevier>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, gns, mrobinson, webkit.review.bot, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch proposal none

Description arno. 2012-07-10 13:49:20 PDT
WebKit supports optionnaly css3 filters.
But currenly, autoconf and automake do not support the flag.
Comment 1 arno. 2012-07-10 13:54:34 PDT
Created attachment 151517 [details]
patch proposal

with this patch, it's possible to build gtk port with css filters support: build-webkit --gtk --css-filters
Comment 2 Eric Seidel (no email) 2012-07-10 14:30:04 PDT
Comment on attachment 151517 [details]
patch proposal

rs=me.
Comment 3 Martin Robinson 2012-07-10 14:47:11 PDT
Just going to cancel the commit queue for the moment, so that Zan can double-check this patch.
Comment 4 Martin Robinson 2012-07-10 14:47:51 PDT
Zan, do you mind doing an informal review of this patch. I'm not certain if we can skip the addition of the new configuration option or not.
Comment 5 Zan Dobersek 2012-07-11 00:22:55 PDT
(In reply to comment #4)
> Zan, do you mind doing an informal review of this patch. I'm not certain if we can skip the addition of the new configuration option or not.

I think it's OK to add a configuration flag since it's currently the only way to enable the feature. Later, with GNUmakefile.features.am, it should be determined whether the feature can be enabled by default (at least in developer builds).
Comment 6 WebKit Review Bot 2012-07-11 11:15:03 PDT
Comment on attachment 151517 [details]
patch proposal

Clearing flags on attachment: 151517

Committed r122346: <http://trac.webkit.org/changeset/122346>
Comment 7 WebKit Review Bot 2012-07-11 11:15:09 PDT
All reviewed patches have been landed.  Closing bug.