Bug 90905 – webkit-patch rebaseline doesn't work for audio/pixel tests

• Component: New Bugs
• Status: RESOLVED FIXED

[Ojan Vafai]

webkit-patch rebaseline doesn't work for audio/pixel tests

[Ojan Vafai]

Created attachment 151514 [details]
Patch

[Adam Barth]

Comment on attachment 151514 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151514&action=review

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:421
> +                test_list[test][builder.name()] = self._suffixes_to_update(options)

I assume this does something sensible if the requested suffix doesn't exist on the server.

[Ojan Vafai]

(In reply to comment #2)
> (From update of attachment 151514 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151514&action=review
> 
> > Tools/Scripts/webkitpy/tool/commands/rebaseline.py:421
> > +                test_list[test][builder.name()] = self._suffixes_to_update(options)
> 
> I assume this does something sensible if the requested suffix doesn't exist on the server.

Yup.

[Ojan Vafai]

Committed r122258: <http://trac.webkit.org/changeset/122258>

[Dirk Pranke]

Comment on attachment 151514 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151514&action=review

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:404
> +        return suffixes

minor nit ... if you specify the same suffix multiple times on the command line, this doesn't de-dup them, and it doesn't look like the underlying code checks for this either. Someone probably should :).