Bug 90902

Summary: Web Inspector: migrate from background images to CSS for statusbar rendering.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch vsevik: review+

Description Pavel Feldman 2012-07-10 12:03:10 PDT
This change removes statusbar* images and uses gradients and borders to re-create original inspector look.
Comment 1 Pavel Feldman 2012-07-11 04:37:25 PDT
Created attachment 151679 [details]
Patch
Comment 2 Andrey Kosyakov 2012-07-11 05:38:33 PDT
Comment on attachment 151679 [details]
Patch

Why status-bar-background is a separate class? It appears that we always used it along with status-bar.
Comment 3 Pavel Feldman 2012-07-11 06:53:04 PDT
Created attachment 151698 [details]
Patch
Comment 4 Andrey Kosyakov 2012-07-11 07:05:36 PDT
Comment on attachment 151698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151698&action=review

> Source/WebKit/chromium/src/js/devTools.css:83
> +.status-bar-background {

Please fix this before landing.
Comment 5 Vsevolod Vlasov 2012-07-11 07:18:17 PDT
Comment on attachment 151698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151698&action=review

> Source/WebCore/inspector/front-end/inspector.css:565
> +    border-bottom: 0 solid transparent;

Looks like too much borders for one rule.
Comment 6 Pavel Feldman 2012-07-11 07:51:00 PDT
Committed r122332: <http://trac.webkit.org/changeset/122332>