Bug 90852

Summary:

REGRESSION(r122166): It made 170 tests crash on 32 bit platforms

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

barraclough, fpizlo, ossy, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

79668, 90731

Attachments:

Description	Flags
the patch	none
better patch	none

Description Csaba Osztrogonác 2012-07-10 00:04:50 PDT

https://trac.webkit.org/changeset/122166 made 170 tests cras on 32 bit platforms.
(at least on Qt and GTK)

GTK: http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r122167%20%2824889%29/results.html
Qt: http://build.webkit.org/results/Qt%20Linux%20Release/r122167%20%2849248%29/results.html

Comment 1 Filip Pizlo 2012-07-10 01:21:22 PDT

Created attachment 151416 [details]
the patch

This might fix it.

Comment 2 Filip Pizlo 2012-07-10 01:30:59 PDT

Created attachment 151417 [details]
better patch

Really fix it this time.

Comment 3 Zoltan Herczeg 2012-07-10 01:49:12 PDT

Comment on attachment 151417 [details]
better patch

r=me

Comment 4 Csaba Osztrogonác 2012-07-10 02:36:25 PDT

Comment on attachment 151417 [details]
better patch

Clearing flags on attachment: 151417

Committed r122208: <http://trac.webkit.org/changeset/122208>

Comment 5 Csaba Osztrogonác 2012-07-10 02:36:32 PDT

All reviewed patches have been landed.  Closing bug.