Summary: | [chromium] Assert in decideRenderPassAllocationsForFrame fails when surface is larger than max texture size | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||
Component: | Layout and Rendering | Assignee: | Dana Jansens <danakj> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | CC: | cc-bugs, danakj, enne, jamesr, piman, webkit.review.bot, wjmaclean, zlieber | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 90573 | ||||||
Attachments: |
|
Description
Hayato Ito
2012-07-09 22:15:17 PDT
I commented out the assertion in http://trac.webkit.org/changeset/122194 as I and hbono discussed. Let me watch the result. These tests are crashing for me locally still, but the assertion has stopped breaking once I adjust it to account for valid reservation failure. So I think this should resolve the problem. Created attachment 151499 [details]
Patch
Comment on attachment 151499 [details] Patch It's weird to me that calling code needs to know about the conditions in which reserve could fail. I think you should either move the assert to reserve itself or punt and let bug 90841 take care of this. ya.. ok punt it is! |