Summary: | REGRESSION (r122168): Layout Test http/tests/misc/script-defer.html is failing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||
Component: | Tools / Tests | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, kadam, mrobinson, ossy, pnormand, tmpsantos, webkit.review.bot, zan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 89102 | ||||||
Attachments: |
|
Description
Hayato Ito
2012-07-09 19:13:49 PDT
Sad. I'm surprised this wasn't caught on cr-linux. maybe cr-linux doesn't run this test? http://trac.webkit.org/changeset/122168 I marked it TEXT TestExpectations on chromium in http://trac.webkit.org/changeset/122186. (In reply to comment #1) > Sad. I'm surprised this wasn't caught on cr-linux. maybe cr-linux doesn't run this test? > http://trac.webkit.org/changeset/122168 That should run. I am not sure why cr-linux could not catch. Is it rare case? > That should run. I am not sure why cr-linux could not catch. Is it rare case?
It looks like Eric's patch just made it flaky. It happened to pass in exactly the right pattern to trick the bot into landing the patch.
It became flakey on GTK and Qt too: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/misc/script-defer-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/misc/script-defer-actual.txt @@ -1,7 +1,9 @@ This tests for proper execution order of scripts with the defer attribute https://bugs.webkit.org/show_bug.cgi?id=20710. external inline +DOMContentLoaded slowDefer +DOMContentLoaded defer DOMContentLoaded load We definitely shoudl not be delivering more than one DOMContentLoaded event. I'll look when I wake tomorrow. I'm also happy to roll out (or have someone roll out) the patch. I've found the bug. Will fix. I skipped this flakey test on Qt. http://trac.webkit.org/changeset/122214/trunk/LayoutTests/platform/qt/Skipped Created attachment 151445 [details]
Patch
(In reply to comment #4) > It became flakey on GTK and Qt too: > --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/misc/script-defer-expected.txt > +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/misc/script-defer-actual.txt > @@ -1,7 +1,9 @@ > This tests for proper execution order of scripts with the defer attribute https://bugs.webkit.org/show_bug.cgi?id=20710. > external > inline > +DOMContentLoaded > slowDefer > +DOMContentLoaded > defer > DOMContentLoaded > load EFL too. Comment on attachment 151445 [details]
Patch
The patch was reviewed, let's try landing it.
Comment on attachment 151445 [details] Patch Clearing flags on attachment: 151445 Committed r122226: <http://trac.webkit.org/changeset/122226> All reviewed patches have been landed. Closing bug. |