Bug 90833

Summary:	fast/js/global-constructors.html is flaky and mostly useless
Product:	WebKit	Reporter:	Filip Pizlo <fpizlo>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, arv, cmarcelo, cmarrin, eric, fpizlo, hamaji, jianli, kbr, ojan, rbyers, zmo
Priority:	P2	Keywords:	LayoutTestFailure
Version:	528+ (Nightly build)
Hardware:	All
OS:	All

Description Filip Pizlo 2012-07-09 16:14:26 PDT

It fails, or doesn't fail, depending on which tests ran prior to it.

But more importantly, the test is mostly useless.  I cannot recall a time when it failed in a manner that helped us pinpoint a bug.  But I can recall many times that it failed spuriously, leading to bot redness and false alarms.

I will skip it on the Mac port.  But I strongly believe that the better solution is to eliminate this test from our repertoire.

Comment 1 Filip Pizlo 2012-07-09 16:17:05 PDT

Most recent failure, which I don't feel like investigating because I already know it'll be a red herring:

http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r122159%20(765)/fast/js/global-constructors-pretty-diff.html

Comment 2 Eric Seidel (no email) 2012-07-09 16:20:59 PDT

I thought Arv had already posted some patches to remove these.  But I may be confused.

Comment 3 Filip Pizlo 2012-07-09 16:22:27 PDT

Skipped on Mac in http://trac.webkit.org/changeset/122165

Comment 4 Kenneth Russell 2012-07-09 16:41:16 PDT

I've personally been responsible for regressions in this test in the past -- but I still think it has value. It should prevent unintended additions of globally visible constructors. Is there a less fragile way to get the same result?

Comment 5 Erik Arvidsson 2012-07-11 15:34:36 PDT

We should either remove it or pick a handful of constructors to test.

Comment 6 Rick Byers 2012-11-22 12:36:18 PST

It looks like many ports now ignore failures in this test (certainly  mac, chromium, win, wincairo, qt).  I just added a new global constructor (bug 96295) and got no failures in EWS as a result.

Comment 7 Alexey Proskuryakov 2013-04-24 15:04:52 PDT

This test was deleted in bug 110573.