Bug 90799

Summary:

Web Inspector: [Extensions API] simplify panel size check in extensions-panel.html

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, keishi, loislo, pfeldman, pmuellr, rik, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

89333, 89790

Attachments:

Description	Flags
Patch	vsevik: review+

Description Andrey Kosyakov 2012-07-09 10:37:54 PDT

We used to have an ugly hack to compare inner extension window size to outer panel size. Now that we have window argument to panel.onShown(), the check can be simplified. This should also remove  flakiness due to additional test output coming from front-end context async wrt extension test output.

Comment 1 Andrey Kosyakov 2012-07-09 10:46:39 PDT

Created attachment 151274 [details]
Patch

Comment 2 Andrey Adaikin 2012-07-10 04:23:49 PDT

Comment on attachment 151274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151274&action=review

> LayoutTests/inspector/extensions/extensions-panel.html:72
> +                output("panel width mismatch, outer: " + result.width + "inner:" + window.innerWidth);

"inner:" -> ", inner:"

> LayoutTests/inspector/extensions/extensions-panel.html:74
> +                output("panel height mismatch, outer: " + result.height + "inner:" + window.innerHeight);

ditto

Comment 3 Andrey Kosyakov 2012-07-10 05:25:06 PDT

Committed r122216: <http://trac.webkit.org/changeset/122216>