Bug 90762

Summary: [WK2] Add C API for Network Information API
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cmarcelo, gustavo, kenneth, menard, rakuco, sam, tmpsantos, webkit.review.bot, xan.lopez, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 90781    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
gustavo: commit-queue-
Patch none

Chris Dumez
Reported 2012-07-09 01:16:16 PDT
We need to add the C API for WKNetworkInfoManager and WKNetworkInfo. We also need to add a C API function to WKContext to retrieve the NetworkInfo manager.
Attachments
Patch (15.67 KB, patch)
2012-07-09 02:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.12 KB, patch)
2012-07-12 22:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.10 KB, patch)
2012-07-12 23:36 PDT, Chris Dumez 		gustavo: commit-queue-
DetailsFormatted DiffDiff
Patch (11.10 KB, patch)
2012-07-13 00:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-07-09 02:30:11 PDT
Created attachment 151219 [details] Patch
Chris Dumez
Comment 2 2012-07-09 05:37:38 PDT
Comment on attachment 151219 [details] Patch Clearing flag until dependency lands and the patch is rebased.
Chris Dumez
Comment 3 2012-07-12 22:57:16 PDT
Created attachment 152157 [details] Patch Rebase on master.
Grzegorz Czajkowski
Comment 4 2012-07-12 23:30:12 PDT
Comment on attachment 152157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152157&action=review > Source/WebKit2/UIProcess/API/C/WKNetworkInfo.cpp:31 > +#if ENABLE(NETWORK_INFO) It looks like toAPI() method is using when the macro is enabled. We can add macro for this include too. > Source/WebKit2/UIProcess/API/C/WKNetworkInfo.cpp:37 > +WK_EXPORT WKTypeID WKNetworkInfoGetTypeID() We can skip WK_EXPORT in cpp files. > Source/WebKit2/UIProcess/API/C/WKNetworkInfo.cpp:46 > +WK_EXPORT WKNetworkInfoRef WKNetworkInfoCreate(double bandwidth, bool isMetered) Ditto.
Chris Dumez
Comment 5 2012-07-12 23:36:03 PDT
Created attachment 152160 [details] Patch Take Grzegorz's feedback into consideration.
Gustavo Noronha (kov)
Comment 6 2012-07-12 23:50:10 PDT
Comment on attachment 152160 [details] Patch Attachment 152160 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13202976
Early Warning System Bot
Comment 7 2012-07-12 23:52:56 PDT
Comment on attachment 152160 [details] Patch Attachment 152160 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13202000
Chris Dumez
Comment 8 2012-07-13 00:44:01 PDT
Created attachment 152172 [details] Patch
Kenneth Rohde Christiansen
Comment 9 2012-07-13 04:26:45 PDT
Comment on attachment 152172 [details] Patch Looks good but maybe andersca wants to have a quick look
Gyuyoung Kim
Comment 10 2012-07-14 05:24:51 PDT
Comment on attachment 152172 [details] Patch Looks good to me too.
Thiago Marcos P. Santos
Comment 11 2012-07-17 12:10:22 PDT
Unit tests?
WebKit Review Bot
Comment 12 2012-07-18 14:22:11 PDT
Comment on attachment 152172 [details] Patch Clearing flags on attachment: 152172 Committed r123016: <http://trac.webkit.org/changeset/123016>
WebKit Review Bot
Comment 13 2012-07-18 14:22:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.