Bug 90741

Summary: Layout Test fast/text-autosizing/simple-paragraph.html is failing
Product: WebKit Reporter: Hayato Ito <hayato>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: abarth, dglazkov, dpranke, johnme, pkasting, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84186    
Attachments:
Description Flags
work in progress
none
work in progress
webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-08 none

Description Hayato Ito 2012-07-08 17:53:43 PDT
The following layout test is failing on WebKit Mac 10.6, Webkit Mac10.6 (dbg) and Webkit Mac10.7.

fast/text-autosizing/simple-paragraph.html

Probable cause:
http://trac.webkit.org/changeset/121907.
Comment 2 Hayato Ito 2012-07-08 18:11:46 PDT
Committed r122064: <http://trac.webkit.org/changeset/122064>
Comment 3 Hayato Ito 2012-07-08 18:13:08 PDT
I maked IMAGE for fast/text-autosizing/simple-paragraph.html in r122064.
Comment 4 Adam Barth 2012-07-08 18:20:22 PDT
Re-opening so that we can fix the problem instead of just suppressing it.
Comment 5 John Mellor 2012-07-09 04:29:52 PDT
Strange - the simple-paragraph-actual.png included in the layout-test-results.zip files available on the flakiness dashboard seems to almost exactly match the rendering I see locally for simple-paragraph-expected.html. Unfortunately the layout-test-results.zip doesn't include the corresponding simple-paragraph-expected.png generated from the -expected.html, so it's hard to see exactly how this failed.

Is there a bug about layout-test-results.zip not including -expected.png files for reftests? It seems that would be very useful.

In the meantime, I guess I need to find someone with a Mac who can reproduce the problem...
Comment 6 Adam Barth 2012-07-12 10:01:37 PDT
I have a Mac.  I can take a look.
Comment 7 Adam Barth 2012-07-12 16:11:15 PDT
Created attachment 152088 [details]
work in progress
Comment 8 Adam Barth 2012-07-12 16:57:20 PDT
Created attachment 152099 [details]
work in progress
Comment 9 WebKit Review Bot 2012-07-12 17:54:14 PDT
Comment on attachment 152099 [details]
work in progress

Attachment 152099 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13201898

New failing tests:
http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html
fast/text-autosizing/simple-paragraph.html
Comment 10 WebKit Review Bot 2012-07-12 17:54:22 PDT
Created attachment 152116 [details]
Archive of layout-test-results from gce-cr-linux-08

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 11 Peter Kasting 2012-07-31 16:05:51 PDT
Adam, were you still working on this?
Comment 12 Adam Barth 2012-07-31 16:13:16 PDT
> Adam, were you still working on this?

Nope.  Our current belief is that this problem will fix itself as we make progress implementing the rest of the text autosizing feature.
Comment 13 John Mellor 2012-08-21 07:09:03 PDT
It looks like this got resolved:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Ftext-autosizing%2Fsimple-paragraph.html

Seems to have started passing since the fix for bug 91660 landed.

I'll mark it WFM since I'm not convinced the underlying cause is gone. There's also a new Mac-only failure: bug 94528.
Comment 14 Dirk Pranke 2012-09-18 17:26:15 PDT
Seems like the last two suppressed tests are no longer failing ?

// Hopefully will be fixed when WK bug 91660 is fixed.
BUGWK90741 MAC : fast/text-autosizing/font-scale-factor.html = IMAGE
BUGWK90741 MAC : fast/text-autosizing/simple-paragraph.html = IMAGE

Removed the suppressions in http://trac.webkit.org/changeset/128949 .
Comment 15 John Mellor 2012-09-18 17:28:46 PDT
Thanks Dirk! Forgot to remove the suppression.