Summary: | [BlackBerry] Race destroying the compositor | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | George Staikos <staikos> | ||||
Component: | WebKit BlackBerry | Assignee: | George Staikos <staikos> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mifenton, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
George Staikos
2012-07-07 14:32:20 PDT
Created attachment 151148 [details]
Patch to fix it. Reviewed and tested already.
No idea how to make a testcase for this. Requires Cascades.
Attachment 151148 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1
Source/WebKit/blackberry/Api/WebPageCompositor_p.h:93: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 151148 [details] Patch to fix it. Reviewed and tested already. Clearing flags on attachment: 151148 Committed r122056: <http://trac.webkit.org/changeset/122056> All reviewed patches have been landed. Closing bug. |