Summary: | Deleting content at the top of prettypatch emails destroys HTML formatting | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alice Cheng <alice_cheng> | ||||||||
Component: | WebKit Website | Assignee: | Alice Cheng <alice_cheng> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ddkilzer, dev+webkit, pknight, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alice Cheng
2012-07-06 13:06:04 PDT
Created attachment 151113 [details]
patch
A patch that fix pretty patch for now.
Will be working on an API that moves all style elements from body to head.
Attachment 151113 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Websites/bugs.webkit.org/ChangeLog', u'Web..." exit_code: 1
Websites/bugs.webkit.org/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 151114 [details]
patch
A patch that fix pretty patch for now.
Will be working on an API that moves all style elements from body to head.
Added bug number in ChangeLog
Comment on attachment 151114 [details]
patch
r=me
Created attachment 151364 [details]
patch
submit for commit queue
Comment on attachment 151114 [details] patch Rejecting attachment 151114 [details] from commit-queue. alice_cheng@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 151114 [details] patch Clearing flags on attachment: 151114 Committed r122338: <http://trac.webkit.org/changeset/122338> All reviewed patches have been landed. Closing bug. |