Summary: | [Gtk] Remove SVG_FEATURES and HTML_FEATURES from Source/WebCore/GNUmakefile.am | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | WebCore Misc. | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, mrobinson, xan.lopez | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 87127 | ||||||
Attachments: |
|
Description
Zan Dobersek
2012-07-06 10:02:31 PDT
Created attachment 151097 [details]
Patch
Comment on attachment 151097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151097&action=review > Source/WebCore/GNUmakefile.am:543 > - $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $< --tags $(WebCore)/svg/svgtags.in --attrs $(WebCore)/svg/svgattrs.in --factory --wrapperFactory --outputDir "$(GENSOURCES_WEBCORE)" > -endif # SVG_FLAGS > + $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $< --tags $(WebCore)/svg/svgtags.in --attrs $(WebCore)/svg/svgattrs.in --extraDefines "$(FEATURE_DEFINES)" --factory --wrapperFactory --outputDir "$(GENSOURCES_WEBCORE)" Isn't this change inducing a "leak" of all (including non-svg) defines in the generated file? A wild guess though, I haven't looked at this perl script. (In reply to comment #2) > (From update of attachment 151097 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151097&action=review > > Isn't this change inducing a "leak" of all (including non-svg) defines in the generated file? A wild guess though, I haven't looked at this perl script. It technically does, the feature defines are then used when the tags and attributes files are run through the preprocessor[1][2]. Don't think there's any negative effects to it, though. [1] http://trac.webkit.org/browser/trunk/Source/WebCore/dom/make_names.pl#L269 [2] http://trac.webkit.org/browser/trunk/Source/WebCore/dom/make_names.pl#L281 Committed r125408: <http://trac.webkit.org/changeset/125408> |