Bug 90648

Summary: REGRESSION(r121921): caused hundreds of crashes on Mac (Requested by pizlo on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, leandrogracia, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90560    
Attachments:
Description Flags
ROLLOUT of r121921 none

Description WebKit Review Bot 2012-07-05 18:19:13 PDT
http://trac.webkit.org/changeset/121921 broke the build:
caused hundreds of crashes on Mac (Requested by pizlo on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-07-05 18:19:50 PDT
Created attachment 151008 [details]
ROLLOUT of r121921

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Ryosuke Niwa 2012-07-05 18:21:42 PDT
Presumably this is an assertion failure?
Comment 3 Filip Pizlo 2012-07-05 18:27:02 PDT
(In reply to comment #2)
> Presumably this is an assertion failure?

Yes, it was.
Comment 4 WebKit Review Bot 2012-07-05 18:27:50 PDT
Comment on attachment 151008 [details]
ROLLOUT of r121921

Clearing flags on attachment: 151008

Committed r121933: <http://trac.webkit.org/changeset/121933>
Comment 5 WebKit Review Bot 2012-07-05 18:27:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryosuke Niwa 2012-07-05 18:28:28 PDT
It would have been better if we just got rid of the assertions intead.