Bug 9058

Summary:

add wrappers for primitive css types when bridged to objective-c

Product:

WebKit

Reporter:

James G. Speth <speth>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
broken patch - why doesn't it work?	none

James G. Speth

Reported 2006-05-23 02:30:36 PDT

There are a few remaining classes that need to be wrapped properly when bridged to objective-c. These are the ones that did not get fixed in bug 8331. They are DOMRGBColor, DOMRect, and DOMCounter, and I'm sure that it would be a straight-forward fix, and i'm just missing something. I'm attaching a patch in case someone wants to look at what i tried (it doesn't work), and possibly shed some light on this.

Attachments
broken patch - why doesn't it work? (1.59 KB, patch) 2006-05-23 02:31 PDT, James G. Speth	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

James G. Speth

Comment 1 2006-05-23 02:31:44 PDT

Created attachment 8477 [details] broken patch - why doesn't it work?

Geoffrey Garen

Comment 2 2006-05-23 10:51:29 PDT

More info on why this doesn't work would be helpful (failed compile? test case fails?). I think the issue is that you need to implement the xxxWith: methods for the classes in question.

Eric Seidel (no email)

Comment 3 2007-10-11 18:31:56 PDT

These have all been fixed by now.

Note You need to log in before you can comment on or make changes to this bug.