Summary: | Make GC3D and E3D more maintainable for GLES platforms | ||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Netterfield <jnetterfield> | ||||||||||||||||||||||||||||||
Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||
Severity: | Normal | CC: | dglazkov, efidler, fpizlo, gustavo, kbr, ossy, philn, rakuco, rniwa, webkit.review.bot, xan.lopez | ||||||||||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||||||
Bug Depends on: | 90943 | ||||||||||||||||||||||||||||||||
Bug Blocks: | |||||||||||||||||||||||||||||||||
Attachments: |
|
Description
Joshua Netterfield
2012-07-04 09:42:35 PDT
Created attachment 150826 [details]
Patch
Comment on attachment 150826 [details] Patch Attachment 150826 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13131874 Comment on attachment 150826 [details] Patch Attachment 150826 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13136799 Created attachment 150844 [details]
Patch
Attachment 150844 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp:37: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 19 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 150848 [details]
Patch
Comment on attachment 150848 [details] Patch Attachment 150848 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13134880 Created attachment 150956 [details]
Patch
Comment on attachment 150956 [details] Patch Attachment 150956 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13154067 Created attachment 150965 [details]
Patch
Created attachment 150966 [details]
Patch
Created attachment 150969 [details]
Patch
Comment on attachment 150969 [details] Patch Attachment 150969 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13155041 Created attachment 150974 [details]
Patch
Created attachment 150976 [details]
Patch
Created attachment 150977 [details]
Patch
Comment on attachment 150977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150977&action=review Looks good in general, can be cleaned up a bit more. > Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h:2 > + * Copyright (C) 2011 Google Inc. All rights reserved. Should be RIM copyright I think. > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:185 > + No need for empty line. > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:267 > + Ditto. > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:277 > + Ditto. Created attachment 150982 [details]
Patch
Comment on attachment 150982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150982&action=review This patch looks fine to me overall; I'll leave it to Rob or someone who works on one of the other affected ports to r+ it. One comment. > Source/WebCore/platform/graphics/OpenGLESShims.h:2 > + * Copyright (C) 2012 Research In Motion Limited. All rights reserved. This file should use the two-clause BSD license in Source/WebKit/LICENSE. Created attachment 151250 [details]
Patch
Comment on attachment 151250 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151250&action=review Looks good, but needs the ChangeLog fix. > Source/WebCore/ChangeLog:868 > +2012-07-04 Joshua Netterfield <jnetterfield@rim.com> Update date and make sure this is top of the ChangeLog. > Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h:2 > + * Copyright (C) 2011 Google Inc. All rights reserved. Could this use RIM copyright? Created attachment 151255 [details]
Patch
Comment on attachment 151255 [details]
Patch
LGTM.
Comment on attachment 151255 [details] Patch Clearing flags on attachment: 151255 Committed r122116: <http://trac.webkit.org/changeset/122116> All reviewed patches have been landed. Closing bug. Mac build fix landed in http://trac.webkit.org/changeset/122119. This broke five WebGL tests on Mac: http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r122124%20(759)/results.html Reopening because it broke tests. Rolled out in http://trac.webkit.org/changeset/122156 Created attachment 151485 [details]
Patch
Comment on attachment 151485 [details]
Patch
Looks great, and Joshua verified on OS X SL that the fast/canvas/webgl tests pass with this patch.
Comment on attachment 151485 [details] Patch Clearing flags on attachment: 151485 Committed r122250: <http://trac.webkit.org/changeset/122250> All reviewed patches have been landed. Closing bug. (In reply to comment #32) > (From update of attachment 151485 [details]) > Clearing flags on attachment: 151485 > > Committed r122250: <http://trac.webkit.org/changeset/122250> It broke USE(3D_GRAPHICS)=1 and ENABLE(WEBGL)=0 builds - https://bugs.webkit.org/show_bug.cgi?id=90943 Could you check and fix it please? |