Bug 90559

Summary: Hidden dirs are not copied when creating the built product archive
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: Tools / TestsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, ossy, pnormand, svillar, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 90569    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch cgarcia: review+

Sergio Villar Senin
Reported 2012-07-04 08:43:18 PDT
Hidden dirs are not copied when creating the built product archive
Attachments
Patch (1.79 KB, patch)
2012-07-04 08:45 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (1.70 KB, patch)
2012-07-04 10:54 PDT, Sergio Villar Senin 		cgarcia: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2012-07-04 08:45:57 PDT
Created attachment 150806 [details] Patch
Sergio Villar Senin
Comment 2 2012-07-04 08:48:25 PDT
The asterisk ("*") was added as part of another change, I think it had nothing to do with it, and was probably added thinking that it wouldn't hurt. Ossy?
Sergio Villar Senin
Comment 3 2012-07-04 09:11:39 PDT
I have just checked that neither Qt nor EFL had hidden dirs under bin/ and lib/ (the directories they archive) so this will be harmless for them.
Carlos Garcia Campos
Comment 4 2012-07-04 09:34:16 PDT
Comment on attachment 150806 [details] Patch Ok, if it doesn't affect the other ports, the change looks good to me. Thanks!
Sergio Villar Senin
Comment 5 2012-07-04 09:43:14 PDT
Comment on attachment 150806 [details] Patch Clearing flags on attachment: 150806 Committed r121862: <http://trac.webkit.org/changeset/121862>
Sergio Villar Senin
Comment 6 2012-07-04 09:43:21 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2012-07-04 10:42:06 PDT
Re-opened since this is blocked by 90569
Sergio Villar Senin
Comment 8 2012-07-04 10:54:34 PDT
Created attachment 150822 [details] Patch
Sergio Villar Senin
Comment 9 2012-07-04 10:56:09 PDT
If we want to keep the explicit target directory creation then we have to replace the "*" by a "." to include hidden dirs.
Philippe Normand
Comment 10 2012-07-04 11:11:14 PDT
Comment on attachment 150822 [details] Patch Hum, this patch should be based on trunk I think. Right now it doesn't seem to take the rollout in account.
Sergio Villar Senin
Comment 11 2012-07-05 00:04:34 PDT
(In reply to comment #10) > (From update of attachment 150822 [details]) > Hum, this patch should be based on trunk I think. Right now it doesn't seem to take the rollout in account. Yes it does, the original line contained an "*", then the invalid patch removed it. Now I'm replacing the "*" with a ".", so it means that I'm taking into account the rollout.
Carlos Garcia Campos
Comment 12 2012-07-05 00:07:23 PDT
Comment on attachment 150822 [details] Patch Ok, let's try again then.
Sergio Villar Senin
Comment 13 2012-07-05 00:24:40 PDT
Committed r121886: <http://trac.webkit.org/changeset/121886>
Note You need to log in before you can comment on or make changes to this bug.